Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables property #600

Merged
merged 3 commits into from Mar 26, 2015
Merged

Add variables property #600

merged 3 commits into from Mar 26, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2015

Otherwise LogManager.Configuration cannot be used to read variables
defined in XML

closes #518

Otherwise LogManager.Configuration cannot be used to read variables
defined in XML
@ghost ghost added this to the 3.2.1 milestone Feb 21, 2015
@ghost ghost added the bug Bug report / Bug fix label Feb 21, 2015
@304NotModified
Copy link
Member

I find the return null a bit unexpected.

I'm also curious if we could change the variables programmatically. The return null Will make that difficult?

@ghost
Copy link
Author

ghost commented Feb 21, 2015 via email

@304NotModified
Copy link
Member

What do you think about a notsupportedException?

Otherwise it looks like a bug.

But then we need probably another property (e.g. bool variablessupport or something like that)

@ghost
Copy link
Author

ghost commented Feb 21, 2015 via email

@ghost ghost mentioned this pull request Mar 19, 2015
@304NotModified
Copy link
Member

We need this also in 4.0 :)

304NotModified added a commit that referenced this pull request Mar 26, 2015
@304NotModified 304NotModified merged commit 18b3092 into NLog:v3.2.1 Mar 26, 2015
@ghost ghost deleted the VariablesInLoggingConfiguration branch May 16, 2015 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants