-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with WcfLogReceiverClient - alternative #821
Merged
304NotModified
merged 25 commits into
NLog:master
from
304NotModified:wcf-backwardsomp-t4
Aug 26, 2015
Merged
Fix issues with WcfLogReceiverClient - alternative #821
304NotModified
merged 25 commits into
NLog:master
from
304NotModified:wcf-backwardsomp-t4
Aug 26, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Client Postifx are now the facade
This reverts commit fcca6c6.
This was referenced Aug 14, 2015
|
ILogReceiverClient.cs - Breaks compatibility because it doesn't have any of the methods from 3.2.1 For better backwards compatibility to 3.2.1:
For better backwards compatibility to 4.0.1:
For TwoWay Client:
Long Term Suggestions:
|
fixed by #874 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More backwardscompatible to v4. Both one and two way are now unit tested with a
ServiceHost
Keep the facade idea, but a bit different
WcfLogReceiverClient
is renamed toWcfLogReceiverOneWayClient
. We have nowWcfLogReceiverOneWayClient
andWcfLogReceiverTwoWayClient
. Both will implement the same (new) interface.WcfLogReceiverClientFacade
is renamed toWcfLogReceiverClient
WcfLogReceiverClient
(the facade) now delegates (almost) everything ofWcfLogReceiverOneWayClient
/WcfLogReceiverTwoWayClient
.WcfLogReceiverClient
has aProxy
property, if still something is missing (cast is probably required for the end-user)Things to think about:
ILogReceiverClient
is renamed toILogReceiverOneWayClient
. This is not needed, maybe revert it. (there are already some inconsistent namings to bad)WcfLogReceiverOneWayClient
andWcfLogReceiverTwoWayClient
does contain code duplication due to the ClientBase inheritance. Difficult to solve with delegates. Maybe fix with T4.TODO