AreaShop crash the entire server :/

[TNTUP]

Current behavior

[11:22:28] [Server thread/ERROR]: [AreaShop] Reached replacement limit, probably has replacements loops, problematic message key: info-friendRemove, first characters of the message: %lang:info-friend|%0%|%[red]✕[gray] hover: Region %region% hover: %lang:action|Remove %0% as f
[11:22:28] [Server thread/ERROR]: [AreaShop] Reached replacement limit, probably has replacements loops, problematic message key: info-regionFriends, first characters of the message: [darkgreen][bold]►[reset] Added friends: [gray][bold] hover: Player §l%0%§c✕§7, §7§lDivel_Axl§c✕§

http://pastebin.com/NqkaQHeH

New behavior

Should not crash the server

Steps to reproduce (for bugs)

1. I don<t know how it can be triggered it happened two times now

Your environment

• Server platform (Bukkit, Spigot, etc.): Paper #820
• Server version: 1.10.2
• AreaShop version: 2.3.0
• WorldEdit version: 6.1.4 #3595
• WorldGuard version: 6.1.3 #1680
• Vault version: 1.5.6 Areashop Block Break Problem #49

[NLthijs48]

I found the problem and fixed it, basically the argument replacer (tags like %0% in the message) would loop infinitely in a very specific case, when these conditions are met:

• Replacing a %0% causes the replacer to hit the limit (which limits the number of times a replacement run can be done, to prevent infinite replacing).
• The inserted message causes the original message list to grow in size (the message is a list of strings, like the messages in EN.yml).
• The inserted message contains the same tag as that got replaced.

These conditions together cause that the new tag added by the inserted message again gets replaced by the same message, and then the process repeats.

Thanks for your bug report about this, it would not be likely that I found this problem quickly. You can download the development build of AreaShop to prevent this happening again. I will probably release an official 2.3.2 version very soon because problems like these are very critical.