Use configurable MaximumRecursion #368
Conversation
This reverts commit d042996.
tests/build/net45/NLuaTest.csproj
Outdated
| @@ -45,6 +45,7 @@ | |||
| <HintPath>..\..\..\packages\NUnit.3.12.0\lib\net45\nunit.framework.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="System" /> | |||
There was a problem hiding this comment.
Why do we need the System.Data to test this? Can't we use a POCO object? NLua tests will run on Linux, Mac including iOS and tvOS.
There was a problem hiding this comment.
Good point. I will fix this to use one of the test classes.
There was a problem hiding this comment.
So I changed to use the test class but Mac is still failing. Do I need import ('mscorlib','System') in DoString? I'm not sure what I am doing wrong, any help would be much appreciated. I can't see the build log from Mac so am a bit blind here.
tests/src/LuaTests.cs
Outdated
| if(maxRecursion == 0) | ||
| Assert.AreEqual(1,lua.Globals.Count()); //register only the root reference | ||
| else | ||
| Assert.Greater(lua.Globals.Count(),1); //many globals registered (all sub properties) |
There was a problem hiding this comment.
NUnitLite doesn't have Greater you can just do True (lua.Globals.Count() > 1)
There was a problem hiding this comment.
Thanks for helping me with this PR. Looks like there are some failing tests with PlatformNotSupportedException in NLua.CodeGeneration constructor now...
|
Ah looks like those PlatformNotSupported failing tests are also failing in your master branch: https://github.com/NLua/NLua/runs/463903787 |
This PR addresses the issue where you need to give a large object with many child methods as a global variable but want to restrict the amount of up front reflection that happens (for performance).
#366
I have used System.DataTable in the test since it is a good complex class with self referencing properties.
Setting
MaximumRecursionto 0 on an instance ofLuaresults in only a single global being created and no reflection exploration happening (see TestMaximumRecursion).