signed net35, net40 and net45 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome 😄 Can you check why Travis is complaining about your PR? https://travis-ci.org/NLua/NLua/builds/11389481#L341 Thank you |
|
signed libraries can only reference signed libraries. The reason it is failing is coz the signed NLua is trying to reference unsigned KeraLupa and KopiLua. Once you merge the signed KeraLupa and KopiLupa PR I sent, I will update the git submodule so it references the signed kopilua and keralua. That would then fix the Travis complains. |
|
updated the git submodules. it is green now. |
viniciusjarina
added a commit
that referenced
this pull request
Sep 16, 2013
signed net35, net40 and net45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signed desktop profiles
This PR will fail as NLua.dll tries to reference non-signed assemblies.
You will need to merge these NLua/KeraLua#9 and NLua/KopiLua#12 first and update the git submodules so it references the signed assemblies before you merge this in.