Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constructor default function parameters #111

Closed
wants to merge 1 commit into from

Conversation

zhj135
Copy link

@zhj135 zhj135 commented Jul 25, 2019

use default function parameters to remove !options

@NMFR
Copy link
Owner

NMFR commented Aug 30, 2020

Sorry for the super late reply, i have been struggling to find time to dedicate to this repo.

I do agree that your suggestion makes the code more readable, but it will break if someone passes null in the options value.

I will close this PR because of that, but if you come up with a change that handles that null problem and it improves readability i will gladly add it.

Thx for the help.

@NMFR NMFR closed this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants