Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFSocket #46

Merged
merged 8 commits into from Nov 29, 2013
Merged

CFSocket #46

merged 8 commits into from Nov 29, 2013

Conversation

Frugghi
Copy link
Member

@Frugghi Frugghi commented Nov 27, 2013

@Lejdborg can you review the code? Do you approve the changes?

The only advantage of using CFSocket is in the connection method, the code is a lot more clean (and maybe CFSocketConnectToAddress is more optimized than the previous connection code).

The other changes are:

  • Using the channel in blocking mode when possible made the code more clean (no more EAGAIN error checking)
  • The new channelShellDidClose: delegate method can be used to disconnect the session
  • NMSSHChannel now use a dispatch_source instead of a dispatch_queue to read from the buffer when the channel is in shell mode. dispatch_source handler is called only when the socket has data available
  • Host resolution using CFHost (and IPv6 support)

@Lejdborg
Copy link
Collaborator

Sure, I will run some tests and do a proper review sometime this week.

@ghost ghost assigned Lejdborg Nov 27, 2013
@Lejdborg
Copy link
Collaborator

The unit tests run and it looks good. Merging.

Lejdborg pushed a commit that referenced this pull request Nov 29, 2013
@Lejdborg Lejdborg merged commit c8ceed8 into master Nov 29, 2013
@Lejdborg Lejdborg deleted the CFSocket branch November 29, 2013 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants