Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binning information to the commondata format #1006

Closed
Zaharid opened this issue Nov 12, 2020 · 6 comments
Closed

Add binning information to the commondata format #1006

Zaharid opened this issue Nov 12, 2020 · 6 comments
Assignees

Comments

@Zaharid
Copy link
Contributor

Zaharid commented Nov 12, 2020

People complain that the data theory plots in validphys are ugly because they don't include the binning.

In order to solve that we would need e able to read them from somewhere and in turn we need to write them somewhere.

We could make use of the flexibly afforded by having the parser implementation in python to be able to add these things more easily although it is likely that buildmaster would need to be modified as well, but we could disregard the c++ reading part. I think the right format would be to have min and max in addition to central for each of the three kinematics. I think the more reasonable course of action would be to make it an optional feature so that we don't have to update all of the buildmaster files at once. Then the plots would adapt to whether we have binning information or not.

While we are on it we could look into having more than three kinematics, which is limiting.

This could (and likely should) be done after we properly utilize the python based parser.

Does that sound reasonable?

cc @enocera

@enocera
Copy link
Contributor

enocera commented Nov 12, 2020

@Zaharid Would this be a task for NNPDF4.0 or beyond NNPDF4.0?

@wilsonmr
Copy link
Contributor

Given the complexity and the listed dependencies I hope beyond

@enocera
Copy link
Contributor

enocera commented Nov 12, 2020

That's what I wanted to hear, indeed...

@Zaharid
Copy link
Contributor Author

Zaharid commented Nov 12, 2020

Beyond for sure.

@RosalynLP
Copy link
Contributor

I think this is a very good idea and am happy to be involved with implementing it

@scarlehoff
Copy link
Member

Fixed in #1813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants