-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching to theory prediction #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the convention TYPE_DATASETNAME_OBSTYPE_EXTRA
(where EXTRA
can be an additional specificity of the dataset) for consistency and easier manipulation.
PS: I might have missed some places where this appear in the suggestions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below is just a matter of convention again.
For clarity, I'd also use destination_path
instead of just dest
and dataset_path
instead of data_arg
in the click
definitions.
Have you tried that this is working? |
I haven't tried this yet given that I expected that this should not change anything, but let me actually do the change locally. |
Don't worry I should have fixed, thanks in any case. |
Co-authored-by: Tanjona Rabemananjara <rrabeman@nikhef.nl>
Merging this given that its main purpose (namely building the framework to generate and fit Yadism-like datasets) is achieved. Issues related to fit stability are/will be investigated in other PRs. |
This PR is for the implementation of the matching to theory predictions