-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theory error to matching grids #47
Conversation
This LGTM! The uncertainties look better now. I will run a fit and hopefully the results will look better. |
The report for the fit including theory uncertainties is available here: https://data.nnpdf.science/NNUSF/reports/theory-unc-ac1b7cd-221009/output/ The results look good. After other people go through the report, then I can merge this. |
Looks good @Radonirinaunimi ! Just a small comment, I thought we agreed to fluctuate also the pseudo-data, but perhaps this is done on a separate branch and not on this one? |
Yes, indeed, this is still done in a separate branch #56, mainly because we also wanted to assess the effects of each change separately. |
Which is always a very good practice so I don't complain ;) |
Merging this as it is resolved. The last fit with replica 0 as CV and |
Include the theory error in the matching grids using the 7 points prescription