Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inputcard keys #198

Closed
4 of 5 tasks
RoyStegeman opened this issue May 30, 2023 · 5 comments · Fixed by #195
Closed
4 of 5 tasks

Clean up inputcard keys #198

RoyStegeman opened this issue May 30, 2023 · 5 comments · Fixed by #195
Assignees
Labels
refactor Refactor code

Comments

@RoyStegeman
Copy link
Member

RoyStegeman commented May 30, 2023

Originally yadism (and other parts of the pineline) were constructed to consume the same inputcards (inspired by APFEL). Since the design choice of the pineline has shifted to each part doing it's own tasks and producing the grids with pineko it no longer makes sense that all individual codes should consume the same inputcards. Therefore the following (most likely incomplete) list of things should be changed:

  • NfFF is not consumed by yadism and instead just translates to possible settings for mass thresholds making it superfluous. NfFF should be removed in favour of explicitly writing the thresholds in the yadism theorycard as agreed here: Numerical FONLL #195 (comment). NfFF is much more convenient and less prone to errors than setting the thresholds, even if it means that the thresholds from the theorycard are not applied in the case of a FFNS in yadism (which is almost always the case).
  • Without FONLL Numerical FONLL #195 there is no longer a need to distinguish kDISqThr from kqThr. Yadism should only use one of them.
  • This should be decided. There is some ambiguity in the definition of the light flavour. Therefore we may want to only use it as an internal flavour for the calculation of total and not expose it to the user. Superseded by Light structure functions à la FONLL #200 .
  • Remove PTO in favour of PTODIS Don't because we need this for FFN0 in FONLL-B where PTO=PTODIS-1
  • Remove DAMP as the FONLL prescription has been moved to pineko
@RoyStegeman RoyStegeman self-assigned this May 30, 2023
@RoyStegeman RoyStegeman added the refactor Refactor code label May 30, 2023
@giacomomagni
Copy link
Collaborator

Also DAMP is not consumed anymore in Yadism after #195.
We might consider to clean up also cross_constrain.yaml which contains keys not present anymore.

@RoyStegeman
Copy link
Member Author

You're right, thanks for pointing it out, DAMP will be consumed by pineko instead.

Which keys are no longer present?

@giacomomagni
Copy link
Collaborator

I think that file was copied form apfel so not sure if was ever maintained....

For instance:

- krenQ
- kfacQ
- ScVarProc

but also TimeLike is not Yadism landscape anymore.
And Intrinsic Charm sections can be removed ?

@felixhekhorn
Copy link
Contributor

Consider that the whole input package will be dropped as is (cc @alecandido) - and will be replaced soon™ by InputObjects á là eko

@alecandido
Copy link
Member

Consider that the whole input package will be dropped as is (cc @alecandido) - and will be replaced soon™ by InputObjects á là eko

Exactly, #195 (comment)

@RoyStegeman RoyStegeman linked a pull request Oct 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants