Bugfix: update data type for use_2m_diagnostics_calculated_by_lake_model #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeniseWorthen @uturuncoglu Can you review/approve this pr? We are going to start testing at ufs-community/ufs-weather-model#2264 |
DeniseWorthen
approved these changes
May 16, 2024
uturuncoglu
approved these changes
May 16, 2024
|
@DeniseWorthen @uturuncoglu All tests are done ok at ufs-community/ufs-weather-model#2264. can you merge this pr? |
|
@jkbk2004 I have no rights to merge this PR. So, probably @DeniseWorthen could do it. |
|
@DeniseWorthen is out all next week. Is there a backup for her here? |
BrianCurtis-NOAA
approved these changes
May 20, 2024
|
@jkbk2004 all set here. |
DeniseWorthen
pushed a commit
to DeniseWorthen/CMEPS
that referenced
this pull request
Jun 7, 2024
… integer to logical (NOAA-EMC#119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix the data type of one variable in MED_typedefs.meta. There was an error in the data type used in the physics and all host metadata. The datatype is LOGICAL in the actual FORTRAN code, but was listed as INTEGER in the metadata. This bug was fixed because the new version of the CCPP Framework actually compares metadata to the FORTRAN code.
Change is analogous to NOAA-EMC/fv3atm#831
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #): None
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Should be B4B. This is only a metadata change.
Any User Interface Changes (namelist or namelist defaults changes)?
No
Testing performed
Testing will be reported on in ufs-community/ufs-weather-model#2264