Skip to content

Commit

Permalink
Updated yaml and associated code in response to PR review.
Browse files Browse the repository at this point in the history
  • Loading branch information
andytangborn committed Jul 9, 2024
1 parent 6cd06f6 commit c5ef8ac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions parm/aero/berror/aero_diagb.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ variables:
- mass_fraction_of_sea_salt004_in_air

rescale: 2.0 # rescales the filtered std. dev. by "rescale"
diagb_weight: 0.5
rescale_staticb: 2.0
diagb weight: 0.5
staticb rescaling factor: 2.0
number of halo points: 4
number of neighbors: 16
simple smoothing:
Expand Down
6 changes: 3 additions & 3 deletions utils/chem/chem_diagb.h
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,13 @@ namespace gdasapp {
// Hybrid diagb_weight coefficient
// std = diagb_weight*diagb_std + (1-diagb_weight)*Climat_std
double diagb_weight;
fullConfig.get("diagb_weight", diagb_weight);
fullConfig.get("diagb weight", diagb_weight);
// Initialize and read the climatological background error standard deviation field
oops::Log::info() << "====================== read climat bkg error std dev" << std::endl;
fv3jedi::Increment ClimBkgErrorStdDev(geom, chemVars, cycleDate);
ClimBkgErrorStdDev.zero();
const eckit::LocalConfiguration ClimBkgErrorStdDevConfig(fullConfig,
"Climate background error stddev");
"climate background error stddev");
ClimBkgErrorStdDev.read(ClimBkgErrorStdDevConfig);
atlas::FieldSet ClimBkgErrorStdDevFs;
ClimBkgErrorStdDev.toFieldSet(ClimBkgErrorStdDevFs);
Expand All @@ -260,7 +260,7 @@ namespace gdasapp {

// Staticb rescale
double rescale_staticb;
fullConfig.get("rescale_staticb", rescale_staticb);
fullConfig.get("staticb rescaling factor", rescale_staticb);

// Combine diagb and climatological background errors
fv3jedi::Increment stddev_hybrid(geom, chemVars, cycleDate);
Expand Down

0 comments on commit c5ef8ac

Please sign in to comment.