Merge branch 'develop' into feature/hybrid-B

NOAA-EMC · Jul 11, 2023 · f250fe5 · f250fe5
2 parents 2a0dfdc + 78d5873
commit f250fe5
Show file tree

Hide file tree

Showing 18 changed files with 1,686 additions and 1,709 deletions.
diff --git a/parm/aero/berror/staticb_bump.yaml b/parm/aero/berror/staticb_bump.yaml
diff --git a/parm/aero/berror/staticb_bump_aero.yaml b/parm/aero/berror/staticb_bump_aero.yaml
@@ -0,0 +1,23 @@
+covariance model: SABER
+saber central block:
+  saber block name: BUMP_NICAS
+  read:
+    io:
+      data directory: &staticb_aero_dir $(DATA)/berror
+      files prefix: 'nicas_aero'
+    drivers:
+      multivariate strategy: univariate
+      read local nicas: true
+  saber outer blocks:
+  - saber block name: StdDev
+    read: 
+      model file: 
+        datetime: '2016-06-30T00:00:00Z'
+        set datetime on read: true
+        filetype: fms restart
+        psinfile: true
+        datapath: Data/staticb_aero/
+        filename_core: 20160630.000000.stddev.fv_core.res.nc
+        filename_trcr: 20160630.000000.stddev.fv_tracer.res.nc
+        filename_cplr: 20160630.000000.stddev.coupler.res
+        date: '2016-06-30T00:00:00Z'
diff --git a/parm/land/letkfoi/apply_incr_nml.j2 b/parm/land/letkfoi/apply_incr_nml.j2
@@ -2,7 +2,7 @@
   date_str = "{{ current_cycle | to_YMD }}",
   hour_str = "{{ current_cycle | strftime('%H') }}",
   res = {{ CASE[1:] }},
-  frac_grid = {{ FRAC_GRID | to_f90bool }},
+  frac_grid = .true.,
   rst_path = "{{ DATA }}/anl",
   inc_path = "{{ DATA }}/anl",
   orog_path = "{{ HOMEgfs }}/fix/orog/{{ CASE }}",

diff --git a/parm/land/letkfoi/letkfoi.yaml b/parm/land/letkfoi/letkfoi.yaml
@@ -28,7 +28,7 @@ background:
      template:
        datetime: '{{ current_cycle | to_isotime }}'
        filetype: fms restart
-       state variables: [snwdph,vtype,slmsk]
+       state variables: [snodl,vtype,slmsk]
        datapath: $(DATA)/bkg/mem%mem%/RESTART
        filename_sfcd: '{{ current_cycle | to_fv3time }}.sfc_data.nc'
        filename_cplr: '{{ current_cycle | to_fv3time }}.coupler.res'
@@ -56,5 +56,5 @@ output increment:
   filetype: fms restart
   filename_sfcd: '{{ current_cycle | to_fv3time }}.sfc_data.nc'
   filename_cplr: '{{ current_cycle | to_fv3time }}.coupler.res'
-  state variables: [snwdph,vtype,slmsk]
+  state variables: [snodl,vtype,slmsk]
 
diff --git a/parm/land/obs/config/adpsfc_snow.yaml b/parm/land/obs/config/adpsfc_snow.yaml
@@ -86,6 +86,12 @@ obs filters:
       damping_factor_1: 1.0
       damping_factor_2: 1.0
       background_error_group: BkgError
+  - filter: Perform Action
+    filter variables:
+    - name: totalSnowDepth
+    action:
+      name: assign error
+      error parameter: 40.0
   - filter: Variable Assignment
     assignments:
     - name: GrossErrorProbability/totalSnowDepth

diff --git a/scripts/exgdas_global_marine_analysis_bmat.sh b/scripts/exgdas_global_marine_analysis_bmat.sh
@@ -255,7 +255,7 @@ if false; then
     # TODO: resurect this section when making use of bump 3D in the static B, skip for now
     yaml_bump2d=soca_bump2d.yaml
     clean_yaml $yaml_bump2d
-    $APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_training.x $yaml_bump2d 2>$yaml_bump2d.err
+    $APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_toolbox.x $yaml_bump2d 2>$yaml_bump2d.err
     export err=$?; err_chk
     if [ $err -gt 0  ]; then
         exit $err
@@ -265,7 +265,7 @@ if false; then
     yaml_list=`ls soca_bump3d_*.yaml`
     for yaml in $yaml_list; do
         clean_yaml $yaml
-        $APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_training.x $yaml 2>$yaml.err
+        $APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_toolbox.x $yaml 2>$yaml.err
         export err=$?; err_chk
         if [ $err -gt 0  ]; then
             exit $err
@@ -277,7 +277,7 @@ fi
 ################################################################################
 # Compute convolution coefs for L
 clean_yaml soca_bump_loc.yaml
-$APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_training.x soca_bump_loc.yaml
+$APRUN_OCNANAL $JEDI_BIN/soca_error_covariance_toolbox.x soca_bump_loc.yaml
 export err=$?; err_chk
 if [ $err -gt 0  ]; then
     exit $err

diff --git a/test/atm/global-workflow/CMakeLists.txt b/test/atm/global-workflow/CMakeLists.txt
@@ -59,3 +59,14 @@ add_test(NAME test_gdasapp_atm_jjob_ens_final
   COMMAND ${PROJECT_SOURCE_DIR}/test/atm/global-workflow/jjob_ens_final.sh
           ${PROJECT_BINARY_DIR} ${PROJECT_SOURCE_DIR}
   WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/test/atm/global-workflow/testrun)
+
+# python fix
+  set_tests_properties(
+      test_gdasapp_run_jedi_exe_3dhofx
+      test_gdasapp_run_jedi_exe_3dvar
+      test_gdasapp_run_jedi_exe_3denvar
+      test_gdasapp_run_jedi_exe_letkf
+      PROPERTIES
+          ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}:$ENV{PYTHONPATH}"
+  )
+
diff --git a/test/genYAML_prep_aero.sh b/test/genYAML_prep_aero.sh
@@ -6,7 +6,7 @@ cat > testoutput/genYAML_example_aero.yaml << EOF
 template: ${srcdir}/parm/aero/variational/3dvar_gfs_aero.yaml
 output: ${bindir}/test/testoutput/genYAML_output_3dvar_gfs_aero.yaml
 config:
-  BERROR_YAML: \${PARMgfs}/aero/berror/staticb_bump.yaml
+  BERROR_YAML: \${PARMgfs}/aero/berror/staticb_bump_aero.yaml
   OBS_YAML_DIR: \${PARMgfs}/aero/obs/config
   COMPONENT: chem 
   layout_x: '8'

diff --git a/test/land/letkfoi_snowda.sh b/test/land/letkfoi_snowda.sh
@@ -19,7 +19,7 @@ WORKDIR=$project_binary_dir/test/land/letkfoi_snowda
 RSTDIR=$GDASAPP_TESTDATA/lowres/gdas.$GYMD/$GHR/model_data/atmos/restart
 export OBSDIR=$GDASAPP_TESTDATA/land
 
-GFSv17=${GFSv17:-"NO"}
+GFSv17=${GFSv17:-"YES"}
 DAtype=letkfoi_snow
 
 if [ $GFSv17 == "YES" ]; then

diff --git a/test/land/test_imsproc.sh b/test/land/test_imsproc.sh
@@ -56,7 +56,7 @@ done
 ulimit -Ss unlimited
 ${EXECDIR}/calcfIMS.exe
 
-export PYTHONPATH=$PYTHONPATH:${project_source_dir}/iodaconv/src/:${project_source_dir}/build/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}/pyioda/
+export PYTHONPATH=$PYTHONPATH:${project_source_dir}/iodaconv/src/:${project_source_dir}/build/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}
 IMS_IODA=${EXECDIR}/imsfv3_scf2ioda.py
 
 echo 'do_landDA: calling ioda converter'

diff --git a/test/soca/gw/CMakeLists.txt b/test/soca/gw/CMakeLists.txt
@@ -27,7 +27,7 @@ add_test(NAME test_gdasapp_soca_concatioda
          WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/test/soca/gw/concatioda)
        set_tests_properties(test_gdasapp_soca_concatioda
       PROPERTIES
-      ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/ush:$ENV{PYTHONPATH}")
+      ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/ush:${PROJECT_BINARY_DIR}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}:$ENV{PYTHONPATH}")
 
 # Clean-up
 add_test(NAME test_gdasapp_soca_run_clean
@@ -58,6 +58,10 @@ foreach(jjob ${jjob_list})
          -y ${PROJECT_BINARY_DIR}/test/soca/gw/testrun/run_jjobs_${jjob}.yaml
          ${setup}
     WORKING_DIRECTORY ${PROJECT_BINARY_DIR}/test/soca/gw/testrun)
+  set_tests_properties(${test_name}
+    PROPERTIES
+    ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}:$ENV{PYTHONPATH}")
+
 
   set(setup "--skip") # Only run the setup of the first test, if not, it will hang
                       # waiting for standard input from setup_expt.py