-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase tolerance for lgetkf.x reference check #1148
Comments
Repeat this test on Cactus.
|
@DavidNew-NOAA , what do you think? Should we increase One thing which bothers me is why we need to increase the tolerance by an order of magnitude on Hercules. The var test passes on Hercules with |
@RussTreadon-NOAA I have |
Thank you @DavidNew-NOAA for your question. This prompted me to look more closely at our jcb files.
Note that the I added the prefix
Which way was your intention? Do we want to users to override default tolerances via keywords starting with |
@RussTreadon-NOAA Ah, yes, nice catch. They should match, so be can change the jcb prototypes for the jjob test to be test_float_relative_tolerance and test_float_absolute_tolerance |
@RussTreadon-NOAA caught a bug in the JCB prototype files for the the jjob tests. They are missing "test_" in the keywords for the float tolerances, so that the jjob tests are just using the defaults. #1148 (comment)
Resolved by #1154 |
test_gdasapp_atm_jjob_ens_run
using GDASAppdevelop
at 825f19c (update JEDI hashes) fails on Hercules. This test passes on Hera and Orion.The Hercules failure is due to the reference test after lgetkf runs.
The input yaml ends with
Increasing
float relative tolerance
to1e-05
allows the reference check to pass.1e-06
works on Orion and Hera. Testtest_gdasapp_atm_jjob_ens_run
does not yet run on WCOSS2. It is possible that a largerfloat relative tolerance
is needed on WCOSS2.The text was updated successfully, but these errors were encountered: