-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executable to rule them all #1075
Conversation
Building wont work in the tests because the executables can't be made |
Why not go one step further and have:
or
One executable to rule them all! |
I like it 👍 . That would also give us the flexibility to add some of the pre-and post processing tasks within the same executable too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! I think this is relatively little work for a lot of simplification in terms of workflow, linking executables, and frankly, telling people how to use JEDI.;
FYI @danholdaway , this could be tested with |
I agree that that would be quite nice. Is that still NCO compliant? The line "divide the source files into sub-directories according to the executable they produce" makes it sound like they want separate executables for the gw/sorc/gdas/sorc/code directories. Let me also check that it doesn't make for very massive executables. |
No I think the most NCO compliant solution as I interpret it is one giant |
Ok great, I'll try that out. By the way when I tested this I was expecting to find only gdas_code.x in the bin directory but the |
I would suggest we work on |
@danholdaway I fully expect to not even include the python iodaconv repo when this gets implemented. I suspect we will only be using compiled code for conversion then. |
In this case, we will be linking one |
Ready for final review along with global workflow PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danholdaway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is excellent!
Thanks all. What a day, my first contribution to GDASapp 🥹 |
Changes that accompany GDAS PR (NOAA-EMC/GDASApp/pull/1075) that allows building of a single gdas executable, which should be more compliant with NCO requirements. Addresses NOAA-EMC/GDASApp#1085
Changes e.g.
fv3jedi_variational.x config.yaml
->gdas_fv3jedi.x variational config.yaml
. Do we like this?Pros:
Cons: