Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chem code and yaml for hybrid. #1206

Merged
merged 12 commits into from
Jul 9, 2024
Merged

Add chem code and yaml for hybrid. #1206

merged 12 commits into from
Jul 9, 2024

Conversation

andytangborn
Copy link
Collaborator

chem code and yaml for diagb hybrid.

CoryMartin-NOAA
CoryMartin-NOAA reviewed Jul 3, 2024
View reviewed changes
parm/aero/berror/aero_diffusionparm.yaml.j2 Outdated Show resolved Hide resolved
parm/aero/berror/aero_diagb.yaml.j2 Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
@CoryMartin-NOAA
Copy link
Contributor

@andytangborn next up, can you make the coding norms tests happy, then I will do my next/final review

@andytangborn
Copy link
Collaborator Author

@andytangborn next up, can you make the coding norms tests happy, then I will do my next/final review

sure.

CoryMartin-NOAA
CoryMartin-NOAA reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just naming convention stuff now, otherwise this looks great to me! We can merge this in and then worry about the interpolation, but I think I want the interpolation included before we get the workflow PR ready

parm/aero/berror/aero_diagb.yaml.j2 Outdated Show resolved Hide resolved
parm/aero/berror/aero_diagb.yaml.j2 Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
utils/chem/chem_diagb.h Outdated Show resolved Hide resolved
CoryMartin-NOAA
CoryMartin-NOAA approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! This is going to be a fantastic addition!

@CoryMartin-NOAA CoryMartin-NOAA merged commit c7e0de5 into develop Jul 9, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/diagb_hybrid branch July 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andytangborn @CoryMartin-NOAA