Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't look yet ... #484

Merged
merged 1 commit into from
May 22, 2023
Merged

Don't look yet ... #484

merged 1 commit into from
May 22, 2023

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented May 22, 2023 •
edited
Loading

  • I Reverted/adjusted some of last week's changes, it was complaining when running in the container. Seems fine now for both, container and hera.
  • Update to a yaml config related to the soca bkgerror

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label May 22, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels May 22, 2023
@emcbot
Copy link

emcbot commented May 22, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon May 22 14:49:41 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon May 22 15:51:30 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon May 22 16:06:13 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 49

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels May 22, 2023
@CoryMartin-NOAA
Copy link
Contributor

@guillaumevernieres so I can look now??? 👀 ?

CoryMartin-NOAA
CoryMartin-NOAA approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

RussTreadon-NOAA
RussTreadon-NOAA approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not comment on the correctness of the changes in saber_blocks.yaml. The other changes look OK. The Hera GW-RT tests pass.

Approve.

ShastriPaturi
ShastriPaturi approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@ShastriPaturi ShastriPaturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@guillaumevernieres
Copy link
Contributor Author

1st_place_medal

GDASApp medalist!!!

@guillaumevernieres
Copy link
Contributor Author

Thanks for your reviews @RussTreadon-NOAA , @CoryMartin-NOAA and @ShastriPaturi

@guillaumevernieres guillaumevernieres merged commit eeec02c into develop May 22, 2023
11 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the bugfix/container-socab branch May 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@ShastriPaturi ShastriPaturi ShastriPaturi approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@guillaumevernieres @emcbot @CoryMartin-NOAA @ShastriPaturi @RussTreadon-NOAA