Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distillation of diag file statistics to ocnanalvrfy task #491

Merged
merged 13 commits into from
May 25, 2023

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented May 24, 2023

This adds to the ocnanalvrfy a step that untars and unzips collected diag files from cnvstats and performs some basic averaging on the t and sst variables, with the goal of providing quick statistics from them without the need for post-experiment processing.

Todo issues include removal of the tar and gunzip commands to the jjob (put here to get something working relatively quick), and some refinement of the t filters to get over-ocean observations.

File added:
ush/diag_statistics.py
File changed:
scripts/exgdas_global_marine_analysis_vrfy.py

Addresses #479

@CoryMartin-NOAA CoryMartin-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label May 24, 2023
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, things look fine, my approval depends on how 'permanent' this script is.

ush/diag_statistics.py Outdated Show resolved Hide resolved
ush/diag_statistics.py Outdated Show resolved Hide resolved
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels May 24, 2023
@AndrewEichmann-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA Could you elaborate on the point about permanence?

@emcbot
Copy link

emcbot commented May 24, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed May 24 16:05:34 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed May 24 17:09:25 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed May 24 17:21:57 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 49

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels May 24, 2023
@CoryMartin-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA if this is intended to be used for weeks/months+, then go with import tarfile, if this is just a quick and dirty thing that will go away soon, this is fine.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, otherwise looks good

ush/diag_statistics.py Outdated Show resolved Hide resolved
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CoryMartin-NOAA CoryMartin-NOAA merged commit 5a2a536 into develop May 25, 2023
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/vrfy-stats branch May 25, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants