Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of a climatological ensemble B to the soca B-matrix #492

Merged
merged 1 commit into from
May 24, 2023

Conversation

guillaumevernieres
Copy link
Contributor

Work done

  • Removed the BUMP correlation operator (temporary)
  • Added a bump configuration for localization and its associated implementation
  • Added the clim. ens. B to the saber blocks
  • skipping the B-mat verify job for now. There's something wrong with the dirac implementation, to be revisited.
  • Fixed a bug in test_gdasapp_setup_cycled_exp. I thought we catched that one earlier ...

Issues addressed

@guillaumevernieres
Copy link
Contributor Author

guillaumevernieres commented May 24, 2023

@liuxiao37k , could you have a look at the localization and saber blocks yaml's?

@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label May 24, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels May 24, 2023
@liuxiao37k
Copy link
Collaborator

liuxiao37k commented May 24, 2023

@liuxiao37k , could you have a look at the localization and saber blocks yaml's?

The saber_blocks.yaml changes look fine to me. I tried slightly different parameters (e.g. rescale_bkgerr: 2.5 or 3.0) but those were optimized for a slightly different system as we know...

How was the testing with strategy: crossed? It didn't go well with BGC states, probably because of their huge ranges and numerical truncations when saving the ensembles.

Copy link
Collaborator

@liuxiao37k liuxiao37k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the yaml changes. I didn't run the unit tests.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints, will wait until tests pass to merge

@emcbot
Copy link

emcbot commented May 24, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed May 24 15:20:05 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed May 24 16:19:00 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed May 24 16:33:20 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 48

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels May 24, 2023
@CoryMartin-NOAA CoryMartin-NOAA merged commit 5bad3f8 into develop May 24, 2023
11 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/hybrid-B branch May 24, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a hybrid static B for the marine DA
4 participants