Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all instances of pygw with wxflow #521

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Replace all instances of pygw with wxflow #521

merged 5 commits into from
Jul 12, 2023

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jul 3, 2023 •
edited
Loading

This PR:

  • removes all pygw references and replaces them with wxflow.

See companion PR NOAA-EMC/global-workflow#1722

@RussTreadon-NOAA
Copy link
Contributor

Orion test

Clone g-w branch feature/wxflow. Execute sorc/checkout.sh -u. cd into sorc/gdas.cd and checkout GDASApp branch feature/wxflow. cd back up to sorc/ and execute build_all.sh and link_workflow.sh. cd into sorc/gdas.cd. Load module GDAS/orion. Set ctest environment variables. Execute test_gdasapp ctests with the following results

(gdasapp) Orion-login-2:/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build$ ctest -R test_gdasapp
Test project /work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build
  	Start 1470: test_gdasapp_check_python_norms
 1/49 Test #1470: test_gdasapp_check_python_norms .......................   Passed	1.85 sec
  	Start 1471: test_gdasapp_check_yaml_keys
 2/49 Test #1471: test_gdasapp_check_yaml_keys ..........................   Passed	1.29 sec
  	Start 1472: test_gdasapp_jedi_increment_to_fv3
 3/49 Test #1472: test_gdasapp_jedi_increment_to_fv3 ....................   Passed   13.66 sec
  	Start 1473: test_gdasapp_genYAML_prep
 4/49 Test #1473: test_gdasapp_genYAML_prep .............................   Passed	0.02 sec
  	Start 1474: test_gdasapp_genYAML_run
 5/49 Test #1474: test_gdasapp_genYAML_run ..............................***Failed	8.22 sec
  	Start 1475: test_gdasapp_genYAML_land_prep
 6/49 Test #1475: test_gdasapp_genYAML_land_prep ........................   Passed	0.02 sec
  	Start 1476: test_gdasapp_genYAML_land_run
 7/49 Test #1476: test_gdasapp_genYAML_land_run .........................***Failed	0.29 sec
  	Start 1477: test_gdasapp_genYAML_aero_prep
 8/49 Test #1477: test_gdasapp_genYAML_aero_prep ........................   Passed	0.02 sec
  	Start 1478: test_gdasapp_genYAML_aero_run
 9/49 Test #1478: test_gdasapp_genYAML_aero_run .........................***Failed	0.30 sec
  	Start 1479: test_gdasapp_convert_ewok_yaml
10/49 Test #1479: test_gdasapp_convert_ewok_yaml ........................   Passed	0.17 sec
  	Start 1480: test_gdasapp_setup_cycled_exp
11/49 Test #1480: test_gdasapp_setup_cycled_exp .........................   Passed	2.35 sec
  	Start 1481: test_gdasapp_convert_bufr_temp_dbuoy
12/49 Test #1481: test_gdasapp_convert_bufr_temp_dbuoy ..................   Passed	5.93 sec
  	Start 1482: test_gdasapp_convert_bufr_salt_dbuoy
13/49 Test #1482: test_gdasapp_convert_bufr_salt_dbuoy ..................   Passed	0.22 sec
  	Start 1483: test_gdasapp_convert_bufr_temp_mbuoyb
14/49 Test #1483: test_gdasapp_convert_bufr_temp_mbuoyb .................   Passed	0.18 sec
  	Start 1484: test_gdasapp_convert_bufr_salt_mbuoyb
15/49 Test #1484: test_gdasapp_convert_bufr_salt_mbuoyb .................   Passed	0.18 sec
  	Start 1485: test_gdasapp_convert_bufr_tesacprof
16/49 Test #1485: test_gdasapp_convert_bufr_tesacprof ...................   Passed	0.26 sec
  	Start 1486: test_gdasapp_convert_bufr_trkobprof
17/49 Test #1486: test_gdasapp_convert_bufr_trkobprof ...................   Passed	0.25 sec
  	Start 1487: test_gdasapp_convert_bufr_sfcships
18/49 Test #1487: test_gdasapp_convert_bufr_sfcships ....................   Passed	0.22 sec
  	Start 1488: test_gdasapp_convert_bufr_sfcshipsu
19/49 Test #1488: test_gdasapp_convert_bufr_sfcshipsu ...................   Passed	0.19 sec
  	Start 1489: test_gdasapp_soca_obsdb
20/49 Test #1489: test_gdasapp_soca_obsdb ...............................   Passed	1.81 sec
  	Start 1490: test_gdasapp_soca_nsst_increment_to_mom6
21/49 Test #1490: test_gdasapp_soca_nsst_increment_to_mom6 ..............***Failed   43.54 sec
  	Start 1491: test_gdasapp_soca_prep
22/49 Test #1491: test_gdasapp_soca_prep ................................   Passed	4.33 sec
  	Start 1492: test_gdasapp_soca_concatioda
23/49 Test #1492: test_gdasapp_soca_concatioda ..........................***Failed	0.51 sec
  	Start 1493: test_gdasapp_soca_run_clean
24/49 Test #1493: test_gdasapp_soca_run_clean ...........................   Passed	0.03 sec
  	Start 1494: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
25/49 Test #1494: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed  138.87 sec
  	Start 1495: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT
26/49 Test #1495: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT ....   Passed   42.27 sec
  	Start 1496: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
27/49 Test #1496: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   42.17 sec
  	Start 1497: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
28/49 Test #1497: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.18 sec
  	Start 1498: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
29/49 Test #1498: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   10.15 sec
  	Start 1499: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY
30/49 Test #1499: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY ....   Passed  268.35 sec
  	Start 1500: test_gdasapp_land_create_ens
31/49 Test #1500: test_gdasapp_land_create_ens ..........................   Passed	6.32 sec
  	Start 1501: test_gdasapp_land_imsproc
32/49 Test #1501: test_gdasapp_land_imsproc .............................   Passed   14.54 sec
  	Start 1502: test_gdasapp_land_apply_jediincr
33/49 Test #1502: test_gdasapp_land_apply_jediincr ......................   Passed   13.29 sec
  	Start 1503: test_gdasapp_land_letkfoi_snowda
34/49 Test #1503: test_gdasapp_land_letkfoi_snowda ......................   Passed   69.02 sec
  	Start 1504: test_gdasapp_convert_bufr_adpsfc
35/49 Test #1504: test_gdasapp_convert_bufr_adpsfc ......................   Passed   12.95 sec
  	Start 1505: test_gdasapp_convert_gsi_satbias
36/49 Test #1505: test_gdasapp_convert_gsi_satbias ......................   Passed	7.13 sec
  	Start 1506: test_gdasapp_store_gsi_satbias
37/49 Test #1506: test_gdasapp_store_gsi_satbias ........................***Failed	6.38 sec
  	Start 1507: test_gdasapp_run_jedi_exe_3dhofx
38/49 Test #1507: test_gdasapp_run_jedi_exe_3dhofx ......................   Passed   32.05 sec
  	Start 1508: test_gdasapp_run_jedi_exe_3dvar
39/49 Test #1508: test_gdasapp_run_jedi_exe_3dvar .......................   Passed	9.39 sec
  	Start 1509: test_gdasapp_run_jedi_exe_3denvar
40/49 Test #1509: test_gdasapp_run_jedi_exe_3denvar .....................   Passed	9.99 sec
  	Start 1510: test_gdasapp_run_jedi_exe_letkf
41/49 Test #1510: test_gdasapp_run_jedi_exe_letkf .......................   Passed	6.91 sec
  	Start 1511: test_gdasapp_setup_atm_cycled_exp
42/49 Test #1511: test_gdasapp_setup_atm_cycled_exp .....................   Passed	0.55 sec
  	Start 1512: test_gdasapp_atm_jjob_var_init
43/49 Test #1512: test_gdasapp_atm_jjob_var_init ........................   Passed   43.03 sec
  	Start 1513: test_gdasapp_atm_jjob_var_run
44/49 Test #1513: test_gdasapp_atm_jjob_var_run .........................   Passed  106.10 sec
  	Start 1514: test_gdasapp_atm_jjob_var_final
45/49 Test #1514: test_gdasapp_atm_jjob_var_final .......................   Passed   10.10 sec
  	Start 1515: test_gdasapp_atm_jjob_ens_init
46/49 Test #1515: test_gdasapp_atm_jjob_ens_init ........................   Passed   44.58 sec
  	Start 1516: test_gdasapp_atm_jjob_ens_run
47/49 Test #1516: test_gdasapp_atm_jjob_ens_run .........................   Passed  202.62 sec
  	Start 1517: test_gdasapp_atm_jjob_ens_final
48/49 Test #1517: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.11 sec
  	Start 1518: test_gdasapp_aero_gen_3dvar_yaml
49/49 Test #1518: test_gdasapp_aero_gen_3dvar_yaml ......................***Failed	0.09 sec

86% tests passed, 7 tests failed out of 49

Total Test time (real) = 1268.10 sec

The following tests FAILED:
    	1474 - test_gdasapp_genYAML_run (Failed)
    	1476 - test_gdasapp_genYAML_land_run (Failed)
    	1478 - test_gdasapp_genYAML_aero_run (Failed)
    	1490 - test_gdasapp_soca_nsst_increment_to_mom6 (Failed)
    	1492 - test_gdasapp_soca_concatioda (Failed)
    	1506 - test_gdasapp_store_gsi_satbias (Failed)
    	1518 - test_gdasapp_aero_gen_3dvar_yaml (Failed)
Errors while running CTest
Output from these tests are in: /work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
(gdasapp) Orion-login-2:/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build

Repeat the above but use the current head of g-w develop (188344a) and current head of GDASApp develop (6f48fd2). Execute test_gdasapp ctest with the following result

(gdasapp) Orion-login-1:/work2/noaa/da/rtreadon/git/global-workflow/develop/sorc/gdas.cd/build$ ctest -R test_gdasapp
Test project /work2/noaa/da/rtreadon/git/global-workflow/develop/sorc/gdas.cd/build
      Start 1458: test_gdasapp_check_python_norms
 1/49 Test #1458: test_gdasapp_check_python_norms .......................   Passed    4.19 sec
      Start 1459: test_gdasapp_check_yaml_keys
 2/49 Test #1459: test_gdasapp_check_yaml_keys ..........................   Passed    2.49 sec
      Start 1460: test_gdasapp_jedi_increment_to_fv3
 3/49 Test #1460: test_gdasapp_jedi_increment_to_fv3 ....................   Passed   20.27 sec
      Start 1461: test_gdasapp_genYAML_prep
 4/49 Test #1461: test_gdasapp_genYAML_prep .............................   Passed    0.22 sec
      Start 1462: test_gdasapp_genYAML_run
 5/49 Test #1462: test_gdasapp_genYAML_run ..............................   Passed   16.97 sec
      Start 1463: test_gdasapp_genYAML_land_prep
 6/49 Test #1463: test_gdasapp_genYAML_land_prep ........................   Passed    0.04 sec
      Start 1464: test_gdasapp_genYAML_land_run
 7/49 Test #1464: test_gdasapp_genYAML_land_run .........................   Passed    0.73 sec
      Start 1465: test_gdasapp_genYAML_aero_prep
 8/49 Test #1465: test_gdasapp_genYAML_aero_prep ........................   Passed    0.04 sec
      Start 1466: test_gdasapp_genYAML_aero_run
 9/49 Test #1466: test_gdasapp_genYAML_aero_run .........................   Passed    0.75 sec
      Start 1467: test_gdasapp_convert_ewok_yaml
10/49 Test #1467: test_gdasapp_convert_ewok_yaml ........................   Passed    0.87 sec
      Start 1468: test_gdasapp_setup_cycled_exp
11/49 Test #1468: test_gdasapp_setup_cycled_exp .........................   Passed    1.85 sec
      Start 1469: test_gdasapp_convert_bufr_temp_dbuoy
12/49 Test #1469: test_gdasapp_convert_bufr_temp_dbuoy ..................   Passed    7.32 sec
      Start 1470: test_gdasapp_convert_bufr_salt_dbuoy
13/49 Test #1470: test_gdasapp_convert_bufr_salt_dbuoy ..................   Passed    0.29 sec
      Start 1471: test_gdasapp_convert_bufr_temp_mbuoyb
14/49 Test #1471: test_gdasapp_convert_bufr_temp_mbuoyb .................   Passed    0.24 sec
      Start 1472: test_gdasapp_convert_bufr_salt_mbuoyb
15/49 Test #1472: test_gdasapp_convert_bufr_salt_mbuoyb .................   Passed    0.24 sec
      Start 1473: test_gdasapp_convert_bufr_tesacprof
16/49 Test #1473: test_gdasapp_convert_bufr_tesacprof ...................   Passed    0.53 sec
      Start 1474: test_gdasapp_convert_bufr_trkobprof
17/49 Test #1474: test_gdasapp_convert_bufr_trkobprof ...................   Passed    0.34 sec
      Start 1475: test_gdasapp_convert_bufr_sfcships
18/49 Test #1475: test_gdasapp_convert_bufr_sfcships ....................   Passed    0.25 sec
      Start 1476: test_gdasapp_convert_bufr_sfcshipsu
19/49 Test #1476: test_gdasapp_convert_bufr_sfcshipsu ...................   Passed    0.35 sec
      Start 1477: test_gdasapp_soca_obsdb
20/49 Test #1477: test_gdasapp_soca_obsdb ...............................   Passed    1.32 sec
      Start 1478: test_gdasapp_soca_nsst_increment_to_mom6
21/49 Test #1478: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed   40.25 sec
      Start 1479: test_gdasapp_soca_prep
22/49 Test #1479: test_gdasapp_soca_prep ................................   Passed    5.91 sec
      Start 1480: test_gdasapp_soca_concatioda
23/49 Test #1480: test_gdasapp_soca_concatioda ..........................   Passed    2.65 sec
      Start 1481: test_gdasapp_soca_run_clean
24/49 Test #1481: test_gdasapp_soca_run_clean ...........................   Passed    0.04 sec
      Start 1482: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
25/49 Test #1482: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   42.86 sec
      Start 1483: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT
26/49 Test #1483: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT ....   Passed   74.27 sec
      Start 1484: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
27/49 Test #1484: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   42.24 sec
      Start 1485: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
28/49 Test #1485: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   74.25 sec
      Start 1486: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
29/49 Test #1486: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   10.23 sec
      Start 1487: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY
30/49 Test #1487: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY ....   Passed  171.00 sec
      Start 1488: test_gdasapp_land_create_ens
31/49 Test #1488: test_gdasapp_land_create_ens ..........................   Passed   12.46 sec
      Start 1489: test_gdasapp_land_imsproc
32/49 Test #1489: test_gdasapp_land_imsproc .............................   Passed    9.70 sec
      Start 1490: test_gdasapp_land_apply_jediincr
33/49 Test #1490: test_gdasapp_land_apply_jediincr ......................   Passed    6.40 sec
      Start 1491: test_gdasapp_land_letkfoi_snowda
34/49 Test #1491: test_gdasapp_land_letkfoi_snowda ......................   Passed   32.39 sec
      Start 1492: test_gdasapp_convert_bufr_adpsfc
35/49 Test #1492: test_gdasapp_convert_bufr_adpsfc ......................   Passed    8.95 sec
      Start 1493: test_gdasapp_convert_gsi_satbias
36/49 Test #1493: test_gdasapp_convert_gsi_satbias ......................   Passed    5.91 sec
      Start 1494: test_gdasapp_store_gsi_satbias
37/49 Test #1494: test_gdasapp_store_gsi_satbias ........................   Passed    6.68 sec
      Start 1495: test_gdasapp_run_jedi_exe_3dhofx
38/49 Test #1495: test_gdasapp_run_jedi_exe_3dhofx ......................   Passed   94.77 sec
      Start 1496: test_gdasapp_run_jedi_exe_3dvar
39/49 Test #1496: test_gdasapp_run_jedi_exe_3dvar .......................   Passed   13.31 sec
      Start 1497: test_gdasapp_run_jedi_exe_3denvar
40/49 Test #1497: test_gdasapp_run_jedi_exe_3denvar .....................   Passed   12.84 sec
      Start 1498: test_gdasapp_run_jedi_exe_letkf
41/49 Test #1498: test_gdasapp_run_jedi_exe_letkf .......................   Passed    9.62 sec
      Start 1499: test_gdasapp_setup_atm_cycled_exp
42/49 Test #1499: test_gdasapp_setup_atm_cycled_exp .....................   Passed    1.70 sec
      Start 1500: test_gdasapp_atm_jjob_var_init
43/49 Test #1500: test_gdasapp_atm_jjob_var_init ........................   Passed   45.67 sec
      Start 1501: test_gdasapp_atm_jjob_var_run
44/49 Test #1501: test_gdasapp_atm_jjob_var_run .........................   Passed  106.18 sec
      Start 1502: test_gdasapp_atm_jjob_var_final
45/49 Test #1502: test_gdasapp_atm_jjob_var_final .......................   Passed   42.18 sec
      Start 1503: test_gdasapp_atm_jjob_ens_init
46/49 Test #1503: test_gdasapp_atm_jjob_ens_init ........................   Passed   45.58 sec
      Start 1504: test_gdasapp_atm_jjob_ens_run
47/49 Test #1504: test_gdasapp_atm_jjob_ens_run .........................   Passed  171.03 sec
      Start 1505: test_gdasapp_atm_jjob_ens_final
48/49 Test #1505: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.20 sec
      Start 1506: test_gdasapp_aero_gen_3dvar_yaml
49/49 Test #1506: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.47 sec

100% tests passed, 0 tests failed out of 49

Total Test time (real) = 1192.01 sec
(gdasapp) Orion-login-1:/work2/noaa/da/rtreadon/git/global-workflow/develop/sorc/gdas.cd/build$

Reran test_gdasapp_genYAML_run for feature/wxflow with -VV. The following traceback is generated

1474: Test command: /work2/noaa/da/python/opt/core/miniconda3/4.6.14/envs/gdasapp/bin/python3.7 "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/genYAML" "--config" "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build/test/testoutput/genYAML_example.yaml"
1474: Environment variables:
1474:  PYTHONPATH=/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build/ush:/work/noaa/epic-ps/role-epic-ps/spack-stack/spack-stack-1.3.1/envs/unified-env/install/intel/2022.0.2/py-pybind11-2.8.1-qrj27tb/lib/python3.9/site-packages:/work/noaa/epic-ps/role-epic-ps/spack-stack/spack-stack-1.3.1/envs/unified-env/install/intel/2022.0.2/bufr-11.7.1-4gljmff/lib/python3.9/site-packages
1474:  PARMgfs=/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/parm
1474: Test timeout computed to be: 1500
1474: Traceback (most recent call last):
1474:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/genYAML", line 12, in <module>
1474:     from ufsda.genYAML import genYAML
1474:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/ufsda/__init__.py", line 3, in <module>
1474:     import ufsda.archive
1474:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/ufsda/archive.py", line 8, in <module>
1474:     from wxflow.yaml_file import YAMLFile
1474: ModuleNotFoundError: No module named 'wxflow'
1/1 Test #1474: test_gdasapp_genYAML_run .........***Failed    5.63 sec

@RussTreadon-NOAA
Copy link
Contributor

Six of the feature/wxflow ctest failures are due to sorc/gdas.cd/ush/ufsda/archive.py being unable to locate module wxflow. For example, the test_gdasapp_genYAML_land_run traceback contains

1476: Traceback (most recent call last):
1476:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/genYAML", line 12, in <module>
1476:     from ufsda.genYAML import genYAML
1476:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/ufsda/__init__.py", line 3, in <module>
1476:     import ufsda.archive
1476:   File "/work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/ush/ufsda/archive.py", line 8, in <module>
1476:     from wxflow.yaml_file import YAMLFile
1476: ModuleNotFoundError: No module named 'wxflow'
1/1 Test #1476: test_gdasapp_genYAML_land_run ....***Failed    0.32 sec

As a test add wxflow to the PYTHONPATH specified for test_gdasapp_genYAML_run in test/CMakeLists.txt. Specifically, the change is

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 220f79c..76d4931 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -131,7 +131,7 @@ add_test(NAME test_gdasapp_genYAML_run
 set_tests_properties(
         test_gdasapp_genYAML_run
 PROPERTIES
-ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/ush:$ENV{PYTHONPATH};PARMgfs=${PROJECT_SOURCE_DIR}/parm")
+ENVIRONMENT "PYTHONPATH=${PROJECT_BINARY_DIR}/ush:${PROJECT_SOURCE_DIR}/../../ush/python/wxflow/src:$ENV
{PYTHONPATH};PARMgfs=${PROJECT_SOURCE_DIR}/parm")

 # test for YAML generation from a template for land DA
 add_test(NAME test_gdasapp_genYAML_land_prep

test_gdasapp_genYAML_run passes with this change in place.

Test project /work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build
    Start 1474: test_gdasapp_genYAML_run
1/1 Test #1474: test_gdasapp_genYAML_run .........   Passed    2.95 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   7.93 sec

The last failed test, test_gdasapp_aero_gen_3dvar_yaml, does not reference archive.py. The following setting for PYTHONPATH was added to the driver script, test/aero/genyaml_3dvar.sh, for this test.

# Set python path for workflow utilities and tasks
export HOMEgfs=$srcdir/../../
wxflowPATH="${HOMEgfs}/ush/python:${HOMEgfs}/ush/python/wxflow/src"
PYTHONPATH="${PYTHONPATH:+${PYTHONPATH}:}${wxflowPATH}"
export PYTHONPATH

The test passes with this addition to the script

Test project /work2/noaa/da/rtreadon/git/global-workflow/pr1722/sorc/gdas.cd/build
    Start 1518: test_gdasapp_aero_gen_3dvar_yaml
1/1 Test #1518: test_gdasapp_aero_gen_3dvar_yaml ...   Passed    0.39 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   2.77 sec

While PYTHONPATH could be updated in the appropriate CMakeLists.txt for the remaining failed tests, is more centralized solution preferable? If so, where to we make this centralized addition or change?

@aerorahul
Copy link
Contributor Author

@RussTreadon-NOAA
I am not familiar with the details of the testing in GDASApp or how it leverages pygw.
I think I will close this PR for now as we explore other avenues to use the wxflow.

@aerorahul aerorahul closed this Jul 5, 2023
@aerorahul
Copy link
Contributor Author

Please do not delete the branch feature/wxflow

@CoryMartin-NOAA
Copy link
Contributor

Depending on how stable wxflow is, we can install it in the CI testing and add it to the Hera/Orion GDAS envs

@aerorahul
Copy link
Contributor Author

wxflow is exact copy of what's in the global workflow.

@CoryMartin-NOAA
Copy link
Contributor

Yes, thanks @aerorahul, I meant more as in how frequently will it be updated. If we expect PRs soon, then we need a different solution than installing in our virtual env but if it is a monthly+ cadence, then what I proposed above makes sense I think.

@aerorahul
Copy link
Contributor Author

As with any project, development will come in spurts as new features are requested. We will maintain (to the best of ability and intention) backward compatibility of the API. I don't expect any major disruptions, but I cannot promise minor adjustments won't be needed from time to time (not daily or weekly).

@aerorahul
Copy link
Contributor Author

reopening with updates.

@aerorahul aerorahul reopened this Jul 8, 2023
@CoryMartin-NOAA CoryMartin-NOAA mentioned this pull request Jul 10, 2023
Merged
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jul 10, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Jul 10, 2023
@emcbot
Copy link

emcbot commented Jul 10, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Jul 10 21:20:17 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 10 22:26:30 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jul 10 22:38:56 UTC 2023
Tests: 63% tests passed, 18 tests failed out of 49
	1418 - test_gdasapp_genYAML_run (Failed)
	1420 - test_gdasapp_genYAML_land_run (Failed)
	1422 - test_gdasapp_genYAML_aero_run (Failed)
	1433 - test_gdasapp_soca_obsdb (Failed)
	1434 - test_gdasapp_soca_nsst_increment_to_mom6 (Failed)
	1436 - test_gdasapp_soca_concatioda (Failed)
	1438 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP (Failed)
	1439 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
	1440 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
	1441 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
	1442 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
	1443 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1450 - test_gdasapp_store_gsi_satbias (Failed)
	1457 - test_gdasapp_atm_jjob_var_run (Failed)
	1458 - test_gdasapp_atm_jjob_var_final (Failed)
	1460 - test_gdasapp_atm_jjob_ens_run (Failed)
	1461 - test_gdasapp_atm_jjob_ens_final (Failed)
	1462 - test_gdasapp_aero_gen_3dvar_yaml (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/521/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 10, 2023
@emcbot
Copy link

emcbot commented Jul 10, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Jul 10 16:17:53 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jul 10 17:35:00 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Jul 10 17:55:13 CDT 2023
Tests: 63% tests passed, 18 tests failed out of 49
	1418 - test_gdasapp_genYAML_run (Failed)
	1420 - test_gdasapp_genYAML_land_run (Failed)
	1422 - test_gdasapp_genYAML_aero_run (Failed)
	1433 - test_gdasapp_soca_obsdb (Failed)
	1434 - test_gdasapp_soca_nsst_increment_to_mom6 (Failed)
	1436 - test_gdasapp_soca_concatioda (Failed)
	1438 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP (Failed)
	1439 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT (Failed)
	1440 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN (Failed)
	1441 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT (Failed)
	1442 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST (Failed)
	1443 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1450 - test_gdasapp_store_gsi_satbias (Failed)
	1457 - test_gdasapp_atm_jjob_var_run (Failed)
	1458 - test_gdasapp_atm_jjob_var_final (Failed)
	1460 - test_gdasapp_atm_jjob_ens_run (Failed)
	1461 - test_gdasapp_atm_jjob_ens_final (Failed)
	1462 - test_gdasapp_aero_gen_3dvar_yaml (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/521/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jul 10, 2023
@CoryMartin-NOAA CoryMartin-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Jul 11, 2023
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed orion-GW-RT Queue for automated testing with global-workflow on Orion hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jul 11, 2023
@emcbot
Copy link

emcbot commented Jul 11, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Jul 11 15:01:13 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jul 11 15:52:53 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Jul 11 16:06:24 UTC 2023
Tests: 92% tests passed, 4 tests failed out of 49
	1469 - test_gdasapp_atm_jjob_var_run (Failed)
	1470 - test_gdasapp_atm_jjob_var_final (Failed)
	1472 - test_gdasapp_atm_jjob_ens_run (Failed)
	1473 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/521/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jul 11, 2023
@emcbot
Copy link

emcbot commented Jul 11, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Jul 11 09:46:19 CDT 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Jul 11 10:49:45 CDT 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Jul 11 11:11:14 CDT 2023
Tests: 90% tests passed, 5 tests failed out of 49
	1455 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1469 - test_gdasapp_atm_jjob_var_run (Failed)
	1470 - test_gdasapp_atm_jjob_var_final (Failed)
	1472 - test_gdasapp_atm_jjob_ens_run (Failed)
	1473 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/521/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jul 11, 2023
guillaumevernieres
guillaumevernieres approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work @aerorahul !!!

The only real issue is this test: 1443 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed).
It times out. Happy to ignore for now.

The other failed test are related to "atm" jobs, we can definitely ignore those of course.

@RussTreadon-NOAA
Copy link
Contributor

Orion test
Install g-w develop at 84842f4 along with GDASApp feature/wxflow at 9d0f940. Run GDASApp ctests. 45 out of 49 tests passed. The four tests which failed are

        1457 - test_gdasapp_atm_jjob_var_run (Failed)
        1458 - test_gdasapp_atm_jjob_var_final (Failed)
        1460 - test_gdasapp_atm_jjob_ens_run (Failed)
        1461 - test_gdasapp_atm_jjob_ens_final (Failed)

A check of the log files in /work/noaa/da/rtreadon/git/global_workflow/pr521/sorc/gdas.cd/build/test/atm/global-workflow/testrun shows that the var_run and ens_run jobs failed due to CRTM not being included in the UFO build. The final jobs failed because expected output from the run jobs was not created.

A change was committed to the UFO repository which sets the minimum CRTM version at 3.0.0. GDASApp uses an EMC-specific tag, v2.3-jedi.3_fix.
Given this, revert the local copy UFO CMakeLists.txt back to CRTM 2.3.0

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 270c2893..d3974333 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -62,7 +62,7 @@ find_package( ioda 2.6.0 REQUIRED )
 find_package( oops 1.7.0 REQUIRED )

 # crtm
-find_package( crtm 3.0 QUIET )
+find_package( crtm 2.3 QUIET )
 if( ${crtm_FOUND} )
   message(STATUS "CRTM FOUND; Including CRTM Observation Operator")
 else( ${crtm_FOUND} )

GDASApp was rebuilt and the test_gdasapp_atm suite rerun. All tests passed.

(gdasapp) Orion-login-2:/work/noaa/da/rtreadon/git/global_workflow/pr521/sorc/gdas.cd/build$ ctest -R test_gdasapp_atm_jjob
Test project /work/noaa/da/rtreadon/git/global_workflow/pr521/sorc/gdas.cd/build
    Start 1515: test_gdasapp_atm_jjob_var_init
1/6 Test #1515: test_gdasapp_atm_jjob_var_init ....   Passed   42.99 sec
    Start 1516: test_gdasapp_atm_jjob_var_run
2/6 Test #1516: test_gdasapp_atm_jjob_var_run .....   Passed  171.40 sec
    Start 1517: test_gdasapp_atm_jjob_var_final
3/6 Test #1517: test_gdasapp_atm_jjob_var_final ...   Passed   42.15 sec
    Start 1518: test_gdasapp_atm_jjob_ens_init
4/6 Test #1518: test_gdasapp_atm_jjob_ens_init ....   Passed   43.50 sec
    Start 1519: test_gdasapp_atm_jjob_ens_run
5/6 Test #1519: test_gdasapp_atm_jjob_ens_run .....   Passed  618.34 sec
    Start 1520: test_gdasapp_atm_jjob_ens_final
6/6 Test #1520: test_gdasapp_atm_jjob_ens_final ...   Passed   74.14 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 993.04 sec

As a final check rerun all 49 GDASApp ctests. All 49 tests passed.

(gdasapp) Orion-login-2:/work/noaa/da/rtreadon/git/global_workflow/pr521/sorc/gdas.cd/build$ ctest -R test_gdasapp
Test project /work/noaa/da/rtreadon/git/global_workflow/pr521/sorc/gdas.cd/build
      Start 1473: test_gdasapp_check_python_norms
 1/49 Test #1473: test_gdasapp_check_python_norms .......................   Passed    1.68 sec
      Start 1474: test_gdasapp_check_yaml_keys
 2/49 Test #1474: test_gdasapp_check_yaml_keys ..........................   Passed    0.48 sec
      Start 1475: test_gdasapp_jedi_increment_to_fv3
 3/49 Test #1475: test_gdasapp_jedi_increment_to_fv3 ....................   Passed    1.81 sec
      Start 1476: test_gdasapp_genYAML_prep
 4/49 Test #1476: test_gdasapp_genYAML_prep .............................   Passed    0.04 sec
      Start 1477: test_gdasapp_genYAML_run
 5/49 Test #1477: test_gdasapp_genYAML_run ..............................   Passed   19.65 sec
      Start 1478: test_gdasapp_genYAML_land_prep
 6/49 Test #1478: test_gdasapp_genYAML_land_prep ........................   Passed    0.02 sec
      Start 1479: test_gdasapp_genYAML_land_run
 7/49 Test #1479: test_gdasapp_genYAML_land_run .........................   Passed    0.59 sec
      Start 1480: test_gdasapp_genYAML_aero_prep
 8/49 Test #1480: test_gdasapp_genYAML_aero_prep ........................   Passed    0.06 sec
      Start 1481: test_gdasapp_genYAML_aero_run
 9/49 Test #1481: test_gdasapp_genYAML_aero_run .........................   Passed    0.68 sec
      Start 1482: test_gdasapp_convert_ewok_yaml
10/49 Test #1482: test_gdasapp_convert_ewok_yaml ........................   Passed    0.22 sec
      Start 1483: test_gdasapp_setup_cycled_exp
11/49 Test #1483: test_gdasapp_setup_cycled_exp .........................   Passed    0.65 sec
      Start 1484: test_gdasapp_convert_bufr_temp_dbuoy
12/49 Test #1484: test_gdasapp_convert_bufr_temp_dbuoy ..................   Passed    4.58 sec
      Start 1485: test_gdasapp_convert_bufr_salt_dbuoy
13/49 Test #1485: test_gdasapp_convert_bufr_salt_dbuoy ..................   Passed    0.21 sec
      Start 1486: test_gdasapp_convert_bufr_temp_mbuoyb
14/49 Test #1486: test_gdasapp_convert_bufr_temp_mbuoyb .................   Passed    0.23 sec
      Start 1487: test_gdasapp_convert_bufr_salt_mbuoyb
15/49 Test #1487: test_gdasapp_convert_bufr_salt_mbuoyb .................   Passed    0.21 sec
      Start 1488: test_gdasapp_convert_bufr_tesacprof
16/49 Test #1488: test_gdasapp_convert_bufr_tesacprof ...................   Passed    0.23 sec
      Start 1489: test_gdasapp_convert_bufr_trkobprof
17/49 Test #1489: test_gdasapp_convert_bufr_trkobprof ...................   Passed    0.23 sec
      Start 1490: test_gdasapp_convert_bufr_sfcships
18/49 Test #1490: test_gdasapp_convert_bufr_sfcships ....................   Passed    0.21 sec
      Start 1491: test_gdasapp_convert_bufr_sfcshipsu
19/49 Test #1491: test_gdasapp_convert_bufr_sfcshipsu ...................   Passed    0.22 sec
      Start 1492: test_gdasapp_soca_obsdb
20/49 Test #1492: test_gdasapp_soca_obsdb ...............................   Passed    1.27 sec
      Start 1493: test_gdasapp_soca_nsst_increment_to_mom6
21/49 Test #1493: test_gdasapp_soca_nsst_increment_to_mom6 ..............   Passed   44.35 sec
      Start 1494: test_gdasapp_soca_prep
22/49 Test #1494: test_gdasapp_soca_prep ................................   Passed    3.22 sec
      Start 1495: test_gdasapp_soca_concatioda
23/49 Test #1495: test_gdasapp_soca_concatioda ..........................   Passed    2.55 sec
      Start 1496: test_gdasapp_soca_run_clean
24/49 Test #1496: test_gdasapp_soca_run_clean ...........................   Passed    1.19 sec
      Start 1497: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
25/49 Test #1497: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP ....   Passed   43.47 sec
      Start 1498: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT
26/49 Test #1498: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT ....   Passed   74.23 sec
      Start 1499: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
27/49 Test #1499: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN .....   Passed   74.19 sec
      Start 1500: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
28/49 Test #1500: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT ...   Passed   42.17 sec
      Start 1501: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
29/49 Test #1501: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_POST ....   Passed   10.15 sec
      Start 1502: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY
30/49 Test #1502: test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY ....   Passed  234.20 sec
      Start 1503: test_gdasapp_land_create_ens
31/49 Test #1503: test_gdasapp_land_create_ens ..........................   Passed    1.07 sec
      Start 1504: test_gdasapp_land_imsproc
32/49 Test #1504: test_gdasapp_land_imsproc .............................   Passed    4.88 sec
      Start 1505: test_gdasapp_land_apply_jediincr
33/49 Test #1505: test_gdasapp_land_apply_jediincr ......................   Passed    5.13 sec
      Start 1506: test_gdasapp_land_letkfoi_snowda
34/49 Test #1506: test_gdasapp_land_letkfoi_snowda ......................   Passed   10.06 sec
      Start 1507: test_gdasapp_convert_bufr_adpsfc
35/49 Test #1507: test_gdasapp_convert_bufr_adpsfc ......................   Passed    6.58 sec
      Start 1508: test_gdasapp_convert_gsi_satbias
36/49 Test #1508: test_gdasapp_convert_gsi_satbias ......................   Passed    4.57 sec
      Start 1509: test_gdasapp_store_gsi_satbias
37/49 Test #1509: test_gdasapp_store_gsi_satbias ........................   Passed    0.78 sec
      Start 1510: test_gdasapp_run_jedi_exe_3dhofx
38/49 Test #1510: test_gdasapp_run_jedi_exe_3dhofx ......................   Passed   14.40 sec
      Start 1511: test_gdasapp_run_jedi_exe_3dvar
39/49 Test #1511: test_gdasapp_run_jedi_exe_3dvar .......................   Passed    8.71 sec
      Start 1512: test_gdasapp_run_jedi_exe_3denvar
40/49 Test #1512: test_gdasapp_run_jedi_exe_3denvar .....................   Passed    8.93 sec
      Start 1513: test_gdasapp_run_jedi_exe_letkf
41/49 Test #1513: test_gdasapp_run_jedi_exe_letkf .......................   Passed    6.89 sec
      Start 1514: test_gdasapp_setup_atm_cycled_exp
42/49 Test #1514: test_gdasapp_setup_atm_cycled_exp .....................   Passed    0.71 sec
      Start 1515: test_gdasapp_atm_jjob_var_init
43/49 Test #1515: test_gdasapp_atm_jjob_var_init ........................   Passed   75.06 sec
      Start 1516: test_gdasapp_atm_jjob_var_run
44/49 Test #1516: test_gdasapp_atm_jjob_var_run .........................   Passed  106.42 sec
      Start 1517: test_gdasapp_atm_jjob_var_final
45/49 Test #1517: test_gdasapp_atm_jjob_var_final .......................   Passed   42.13 sec
      Start 1518: test_gdasapp_atm_jjob_ens_init
46/49 Test #1518: test_gdasapp_atm_jjob_ens_init ........................   Passed   43.44 sec
      Start 1519: test_gdasapp_atm_jjob_ens_run
47/49 Test #1519: test_gdasapp_atm_jjob_ens_run .........................   Passed  234.35 sec
      Start 1520: test_gdasapp_atm_jjob_ens_final
48/49 Test #1520: test_gdasapp_atm_jjob_ens_final .......................   Passed   42.11 sec
      Start 1521: test_gdasapp_aero_gen_3dvar_yaml
49/49 Test #1521: test_gdasapp_aero_gen_3dvar_yaml ......................   Passed    0.34 sec

100% tests passed, 0 tests failed out of 49

Total Test time (real) = 1180.17 sec

Summary: When GDASApp is built on Orion from feature/wxflow with the correct CRTM version, the changes in feature/wxflow do not break existing test_gdasapp ctests. I expect Hera to behave similarly but have not yet run a test on Hera to confirm this expectation.

@aerorahul
Copy link
Contributor Author

aerorahul commented Jul 12, 2023 •
edited
Loading 

100% tests passed, 0 tests failed out of 49

Total Test time (real) = 1180.17 sec

Summary: When GDASApp is built on Orion from feature/wxflow with the correct CRTM version, the changes in feature/wxflow do not break existing test_gdasapp ctests. I expect Hera to behave similarly but have not yet run a test on Hera to confirm this expectation.

Thank you @RussTreadon-NOAA for the validation.

@CoryMartin-NOAA
Copy link
Contributor

Thank you @RussTreadon-NOAA , this should be resolved through a PR just merged to UFO allowing CRTM 2.4 again. We will probably need to move to CRTM 2.4 in GDASApp, but that is probably okay at this point. @ADCollard @emilyhcliu any thoughts?

@CoryMartin-NOAA
Copy link
Contributor

I'm going to merge this in, since several downstream PRs now depend on it

@CoryMartin-NOAA CoryMartin-NOAA merged commit c86d736 into develop Jul 12, 2023
29 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/wxflow branch July 12, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees
No one assigned
Labels
hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aerorahul @RussTreadon-NOAA @CoryMartin-NOAA @emcbot @guillaumevernieres