Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jinja2 templates in snow DA #947

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Mar 2, 2024

This PR:

  • updates the snowDA yamls to jinja2 templates removing all $( ) and ${ } template forms.
  • all inclusion is now performed via jinja2 include with the appropriate indentation.
  • jinja2 templates for yamls now carry a .j2 extension to identify them as templates.
  • requires feature/jinja2_includes branch from wxflow.

parse_j2yaml from wxflow now does not render the $( ) templates. This change is not backwards compatible.

Corressponding PRs in wxflow and global-workflow are:

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, but this looks great, thanks for doing this!

parm/snow/obs/lists/gdas_snow.yaml.j2 Outdated Show resolved Hide resolved
@aerorahul aerorahul marked this pull request as ready for review March 4, 2024 14:20
@CoryMartin-NOAA CoryMartin-NOAA merged commit 37a28d1 into develop Mar 4, 2024
5 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/gdasapp-snowDA-jinja2 branch March 4, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants