Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to spack-stack modules on non-production machines #102

Merged
merged 11 commits into from
Nov 27, 2023

Conversation

DavidHuber-NOAA
Copy link
Collaborator

This upgrades modules to spack-stack-built libraries for all non-production machines. This has been test build on Hera, Orion, Jet, S4, and WCOSS2 and tested on Hera and Orion in a global workflow cycled experiment. Standalone tests were not performed.

Resolves #98

@DavidHuber-NOAA
Copy link
Collaborator Author

I'm not sure how to fix the CI error. During the cmake setup step of the bacio library, it states that ifort is unable to compile a simple program. It seems this is a problem with the spack Intel build of the compiler. Any suggestions @EdwardSafford-NOAA @aerorahul?

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Collaborator

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@EdwardSafford-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Sorry for the delay, I was out last week. Is this good to go now or do you anticipate additional changes?

@DavidHuber-NOAA
Copy link
Collaborator Author

No problem, @EdwardSafford-NOAA! Hope it was a good Thanksgiving!

I tested on all platforms but S4, which @souopgui tested today and I had to make a small change for. He is rerunning the G-W jobs now. Once verified, I'm good with merging.

@DavidHuber-NOAA
Copy link
Collaborator Author

@EdwardSafford-NOAA This worked on S4, so I think it is ready to merge.

@EdwardSafford-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Great! Thanks.

@EdwardSafford-NOAA EdwardSafford-NOAA merged commit ae256c0 into NOAA-EMC:develop Nov 27, 2023
4 checks passed
@DavidHuber-NOAA DavidHuber-NOAA deleted the spack-stack branch December 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use EPIC-managed spack-stack installations for non-production machines
3 participants