Fix use of rgn_find_cycle.pl #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update use of rgn_find_cycle, change default use to radmon.
xyzemc
reviewed
Mar 6, 2024
There was a problem hiding this comment.
Just quick tested this change, it works for rrfs now.
xyzemc
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the calling sequence of
rgn_find_cycle.plwas changed to support both radmon and conmon data. The use ofrgn_find_cycle.plwas not updated inRadMon_IG_rgn.sh. This PR fixes that and makes the default use ofrgn_find_cycle.plradmon instead of conmon. Both work, but radmon is the more common use and should therefore be the default case.Resolves #122 .