Correct install_glb.sh

[EdwardSafford-NOAA]

Install_html.sh script failed because it's child script install_glb.sh was using the incorrect TANKDIR definition. The default location of TANKDIR can be overridden by use of the --tank command line argument. However install_glb.sh was not using this value.

Completes #84

[ADCollard]

So this partially solves the problems I am seeing. It is pointing to the right directory under monitor/ but it still cannot cope with the data files being split into subdirectories of the form gdas.YYYYMMDD/HH or to expand the tar files there. Would that be in a second pull-request?

[EdwardSafford-NOAA]

Hmmm. I was able to successfully run this using your data. On the command line what did you specify for -t|--tank ?

[ADCollard]

I originally did not specify a tankdir as it was set in the config file. But I get the same error putting it in explicilty:
'''
Hera(hfe07):/scratch1/NCEPDEV/da/Andrew.Collard/git/GSI-Monitor_PR/src/Radiance_Monitor/image_gen/html$ ./Install_html.sh v16.3.5_ctl -t /scratch1/NCEPDEV/da/Andrew.Collard/monitor/radmon
BEGIN Install_html.sh

Currently Loaded Modules:

1. hpc/1.1.0 3) hpc-intel/18.0.5.274 5) hpc-impi/2018.0.4 7) prod_util/1.2.2 9) netcdf/4.7.4 11) common-run
2. intel/18.0.5.274 4) impi/2018.0.4 6) grads/2.2.1 8) hdf5/1.10.6 10) wgrib2/2.0.8 12) hera.intel-run

R_TANKDIR = /scratch1/NCEPDEV/da/Andrew.Collard/monitor/radmon
BEGIN install_glb.sh

Do you wish to enable data plots to include comparison to
operational GDAS data, or another data source?

Enter YES to enable comparison plots, any other input to disable. > NO
PDATE=2023050206
ieee_src =
ieee_src is NOGO
ieee_src =
ieee_src is NOGO
ieee_src =
ieee_src is NOGO
ieee_src =
ieee_src is NOGO
ieee_src =
ieee_src is NOGO
ieee_src =
ieee_src is NOGO
Unable to locate any data files in the past 5 days for v16.3.5_ctl
in /scratch1/NCEPDEV/da/Andrew.Collard//monitor/radmon/stats/v16.3.5_ctl/angle.
END Install_html.sh
'''

I should add that this is actually the feature/updt-docs-76 with the changes in this PR hand-edited in. I can try with a fresh pull of this branch.

[EdwardSafford-NOAA]

Yes, I think the problem is with your command line argument for tank. Please try it with this -t /scratch1/NCEPDEV/da/Andrew.Collard/monitor (i.e. leaving off the radmon in your previous attempt).

[ADCollard]

D'oh! So simple! It appears to be working.

[ADCollard]

Thank you!

[EdwardSafford-NOAA]

Adding radmon to your -t string makes intuitive sense, but the mechanism in use to find the files is shared by all the DA monitors and they each handle supplying the monitor name in question. Maybe there's a better way to state that in the documentation. I'll ponder that.

[ADCollard]

I think it's OK as is. I originally left off the radmon, but I added it back in again when trying to solve the other problem that you just fixed.

Maybe just give an example path in step 1 of RadianceMonitor/README (and other READMEs?)?

[EdwardSafford-NOAA]

That's a good suggestion. I'll add that to #76 .