Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated detect_machine.sh. #29

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Updated detect_machine.sh. #29

merged 5 commits into from
Feb 2, 2024

Conversation

HenryRWinterbottom
Copy link
Contributor

Description

This PR addresses issue #28. The following is accomplished:

  • the GSI-utils ush/detect_machine.sh is replaced by the UFS weather-model tests/detect_machine.sh prepared by @BrianCurtis-NOAA

Closes #28.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI/CD will test change.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

aerorahul
aerorahul approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@HenryRWinterbottom
Copy link
Contributor Author

@aerorahul Can this be merged?

@aerorahul aerorahul merged commit 309f49e into NOAA-EMC:develop Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA BrianCurtis-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA Awaiting requested review from RussTreadon-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates to detect_machine.sh needed after the UFSWM updated the return value
4 participants
@HenryRWinterbottom @aerorahul @BrianCurtis-NOAA @henrywinterbottom-wxdev