Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 4D variables in getsfcensmeanp.x utility. #4

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jul 16, 2022

getsfcensmeanp can now handle 4D variables.
Specifically, cldfra was introduced by the UFS-weather-model.
Any/all 4D variables will be averaged in the sfc files.

See commit f1dc784 that adds ability to process 4D variables.

getsfcensmeanp does not handle 4D variables.
skip them
@RussTreadon-NOAA
Copy link
Contributor

Please add @emilyhcliu as a reviewer since this involves cldfra.

@RussTreadon-NOAA
Copy link
Contributor

@aerorahul and @emilyhcliu , I propose a different fix. I added logic to getsfcensmeanp.f90 to handle structures with ndims=4. With this change getsfcensmeanp.f90 can processes a sfc*nc file containing cldfra. However, depending on @yangfanglin 's response to the comment in g-w PR #902, this gsi-utils PR may either be obsolete or not the best resolution of the problem at hand.

@aerorahul
Copy link
Contributor Author

@RussTreadon-NOAA
Your fix is totally fine.
I would like to know why cldfra is in the sfc file, when it is neither a "surface" field nor a "2D" field.
This has implications not just on the sfc filesize, but also on bandwidth, compressibility, and any "convention" that was followed.
The surface file is not using parallel netcdf when doing lower resolutions. Although, this might not matter, it begs the question on adding a variable such as this in a file that is not meant to carry it.

@RussTreadon-NOAA
Copy link
Contributor

@aerorahul , you ask excellent questions which bounce back to the modeling team (@yangfanglin , @junwang-noaa ). For the time being I will add my change to your branch, bugfix/getsfcensmeanp_cld.

@RussTreadon-NOAA
Copy link
Contributor

@aerorahul , I am unable to push commits to github.

Orion-login-3[26] rtreadon$ git status
On branch bugfix/getsfcensmeanp_cldfra
Your branch is ahead of 'origin/bugfix/getsfcensmeanp_cldfra' by 1 commit.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean
Orion-login-3[27] rtreadon$ git push origin bugfix/getsfcensmeanp_cldfra
remote: Permission to NOAA-EMC/GSI-Utils.git denied to RussTreadon-NOAA.
fatal: unable to access 'https://github.com/NOAA-EMC/GSI-Utils.git/': The requested URL returned error: 403
Orion-login-3[28] rtreadon$

@yangfanglin
Copy link

@aerorahul , you ask excellent questions which bounce back to the modeling team (@yangfanglin , @junwang-noaa ). For the time being I will add my change to your branch, bugfix/getsfcensmeanp_cld.

Please see comments I made in NOAA-EMC/global-workflow#902

@aerorahul aerorahul changed the title Skip 4D variables in getsfcensmeanp.x utility. Handle 4D variables in getsfcensmeanp.x utility. Jul 18, 2022
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discuss various paths forward with @aerorahul . For the sake of timeliness, decide to move forward with this PR. A follow up PR can be opened at a later date based on @emilyhcliu's feedback.

@aerorahul aerorahul merged commit 322cc7b into develop Jul 18, 2022
@aerorahul aerorahul deleted the bugfix/getsfcensmeanp_cldfra branch July 18, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants