Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of libsrc from the authoritative repository #302

Closed
MichaelLueken opened this issue Feb 15, 2022 · 4 comments · Fixed by #329
Closed

Removal of libsrc from the authoritative repository #302

MichaelLueken opened this issue Feb 15, 2022 · 4 comments · Fixed by #329
Assignees
@MichaelLueken

Comments

@MichaelLueken
Copy link
Contributor

With wrf_io/1.2.0 available via hpc-stack, there is no longer a reason for the GSI to maintain the libsrc submodule. This issue will detail the steps taken to remove the libsrc submodule from the GSI and add wrf_io/1.2.0 to the modulefiles. This work will be done in the feature/libsrc_removal in my fork.
@MichaelLueken MichaelLueken self-assigned this Feb 15, 2022
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Feb 15, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Removed libsrc directory, reference to lib…
ffcd4b2 
…src in .gitmodules, and added module load wrf_io/1.2.0 to modulefiles/modulefile.ProdGSI.wcoss_d.
@MichaelLueken
Copy link
Contributor Author

At ffcd4b2:

  1. Removed the libsrc directory from the feature/libsrc_removal branch.
  2. Removed the GSI-libsrc reference from .gitmodules file.
  3. Added wrf_io/1.2.0 module to the modulefiles/modulefile.ProdGSI.wcoss_d modulefile.

These changes were tested on WCOSS and all tests passed successfully. Moving on to Hera now.

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Feb 18, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Added module load wrf_io/1.2.0 to modulefi…
cbb75b9 
…les/modulefile.ProdGSI.hera.
@MichaelLueken
Copy link
Contributor Author

At cbb75b9:

Added wrf_io/1.2.0 module to the modulefiles/modulefile.ProdGSI.hera modulefile.

This change was tested on Hera and all tests passed successfully.

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 2, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Merge branch 'master' into feature/libsrc_…
07707c0 
…removal
@MichaelLueken
Copy link
Contributor Author

At 07707c0:

Merged latest updates from the authoritative repository into feature/libsrc_removal

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 2, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. More modulefile updates:
b5d4204 
 * Remove modulefiles/modulefile.ProdGSI.acorn (No reason to touch Acorn - test machine - now that Cactus and Dogwood are both available).
 * modulefiles/modulefile.ProdGSI.jet - Add module load wrf_io/1.2.0
 * modulefiles/modulefile.ProdGSI.orion - Same
 * modulefiles/modulefile.ProdGSI.s4 - Same
@MichaelLueken
Copy link
Contributor Author

At b5d4204:

  1. Removed modulefiles/modulefile.ProdGSI.acorn. Since Acorn was a test machine before we had access to Cactus and Dogwood, there is no reason to maintain obsolete modulefile
  2. Added module load wrf_io/1.2.0 to the rest of the modulefiles that have been updated to compile using hpc-stack:
  • modulefile.ProdGSI.jet
  • modulefile.ProdGSI.orion
  • modulefile.ProdGSI.s4

MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 4, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Removal of libsrc from the authoritative r…
2f3b2a4 
…epository.
@MichaelLueken MichaelLueken mentioned this issue Mar 4, 2022
Merged
MichaelLueken added a commit to MichaelLueken/GSI that referenced this issue Mar 7, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Removal of libsrc from the authoritative r…
ade0522 
…epository.
MichaelLueken added a commit that referenced this issue Mar 9, 2022
@MichaelLueken
Merge pull request #329 from MichaelLueken-NOAA/master
47ee70b 
GitHub Issue #302. Removal of libsrc from the authoritative repository
aerorahul pushed a commit to NOAA-EMC/GSI-Monitor that referenced this issue Jun 2, 2022
@MichaelLueken
GitHub Issue NOAA-EMC/GSI#302. Removal of libsrc from the authoritati…
0e1c660 
…ve repository.
AndrewEichmann-NOAA pushed a commit to AndrewEichmann-NOAA/GSI that referenced this issue Jun 6, 2022
@MichaelLueken
GitHub Issue NOAA-EMC#302. Removal of libsrc from the authoritative r…
88a5736 
…epository.
AndrewEichmann-NOAA pushed a commit to AndrewEichmann-NOAA/GSI that referenced this issue Jun 6, 2022
@MichaelLueken
Merge pull request NOAA-EMC#329 from MichaelLueken-NOAA/master
0df902d 
GitHub Issue NOAA-EMC#302. Removal of libsrc from the authoritative repository
aerorahul pushed a commit to NOAA-EMC/GSI-utils that referenced this issue Jun 30, 2022
@MichaelLueken
GitHub Issue NOAA-EMC/GSI#302. Removal of libsrc from the authoritati…
7650bb5 
…ve repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelLueken MichaelLueken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitHub Issue NOAA-EMC/GSI#302. Removal of libsrc from the authoritative repository MichaelLueken/GSI
1 participant
@MichaelLueken