-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA utility bug fixes #419
Comments
Create forked branch feature/bugfix in which to correct the identified bugs. |
RussTreadon-NOAA
added a commit
to RussTreadon-NOAA/GSI
that referenced
this issue
Jun 23, 2022
MichaelLueken
added a commit
that referenced
this issue
Jun 23, 2022
GitHub Issue #419. correct minor code and link bugs
aerorahul
pushed a commit
to NOAA-EMC/GSI-utils
that referenced
this issue
Jun 30, 2022
aerorahul
pushed a commit
to NOAA-EMC/GSI-utils
that referenced
this issue
Jun 30, 2022
GitHub Issue NOAA-EMC/GSI#419. correct minor code and link bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cycled global parallel tests on Orion identified two small bugs in the authoritative NOAA-EMC/GSI develop.
util/EnKF/gfs/src/getsigensmeanp_smooth.fd/getsigensmeanp_smooth_ncep.f90
When intrinsic
nargs()
replaced withiargc()
, we should have changed the threshold against which we test.nargs()
returns the total number of command line arguments, including the command.iargc()
returns the index of the last command line argument. The line 105 logical test withiargc()
should now check for> 4
, not> 5
. As currently coded theiargq() > 5
test is .false. when the fifth argument for ensemble spread is included on the command line. Changing the logical test toiargc() > 4
restores the intended behavior.util/netcdf_io/calc_analysis.fd/CMakeLists.txt
The target_link_libraries section of
CMakeListx.txt
referencesw3emc_d
. Thew3movdat
call ininit_io.f90
uses a real(4) array. The w3emc_d w3movdat incorrectly processes the input and returns an incorrect date. Linkingw3emc_4
results in the correct behavior fromw3movdat
.This issue is opened to document these bugs and their fixes.
The text was updated successfully, but these errors were encountered: