Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jet Support #529

Closed
DavidHuber-NOAA opened this issue Feb 7, 2023 · 15 comments · Fixed by #537
Closed

Update Jet Support #529

DavidHuber-NOAA opened this issue Feb 7, 2023 · 15 comments · Fixed by #537

Comments

@DavidHuber-NOAA
Copy link
Collaborator

Jet has had hpc-stack installed in a new location and needs its module file updated to reflect that. Additionally, the new regression test data has been placed on Jet so the regression test scripts should also be updated and the RTs run to verify the system.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/GSI that referenced this issue Feb 7, 2023
@DavidHuber-NOAA
Copy link
Collaborator Author

All GSI regression tests pass except the following due to time limits: global_4denvar, rtma, rrfs_3denvar_glbens.

The global_enkf test failed as the sanl* files were not produced. The ENKF did run to completion, but copious warnings about missing data were reported. I'm going to investigate and determine if the data are indeed present and copied/linked in correctly. The ENKF did execute properly when running cycled tests.

@DavidHuber-NOAA
Copy link
Collaborator Author

@RussTreadon-NOAA @CoryMartin-NOAA I ran the problematic global_enkf test on Hera where it is also failing as the sanl* files are not being generated (see the attached log). I will open another issue to track this. In the meantime, do you think I am OK to proceed with a PR to update Jet support?

DavidHuber-NOAA added a commit to DavidHuber-NOAA/GSI that referenced this issue Feb 17, 2023
DavidHuber-NOAA added a commit to DavidHuber-NOAA/GSI that referenced this issue Feb 17, 2023
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Feb 17, 2023
5 tasks
@CoryMartin-NOAA
Copy link
Contributor

@DavidHuber-NOAA does that test fail for you on Hera with develop? If so, I see no reason why it should hold up fixing Jet support.

@DavidHuber-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA Yes, it did, but it was fixed with #532. The test now runs successfully on both Hera and Jet.

@CoryMartin-NOAA
Copy link
Contributor

Ok great, then it sounds like it is fine to proceed with a PR whenever you're ready

@DavidHuber-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA I opened it on Friday actually (#537). By the way, if you have Jet support, I would appreciate the review.

@CoryMartin-NOAA
Copy link
Contributor

@DavidHuber-NOAA I do not unfortunately

@DavidHuber-NOAA
Copy link
Collaborator Author

@CoryMartin-NOAA noted, thanks all the same.

@RussTreadon-NOAA
Copy link
Contributor

@HaidaoLin-NOAA , @guoqing-noaa , @hongli-wang - do any of you have time to review this Jet specific PR?

@hongli-wang
Copy link
Collaborator

@RussTreadon-NOAA I hope I can help but I am not familiar with the Jet HPC environment.

@RussTreadon-NOAA
Copy link
Contributor

@hongli-wang , got it. I'm in the same boat. It's preferable to find a peer reviewer who is familiar with Jet.

@guoqing-noaa
Copy link
Contributor

@RussTreadon-NOAA I can give it a try when Jet is back from today's maintenance.

@RussTreadon-NOAA
Copy link
Contributor

Thank you @guoqing-noaa very much. I'll add you as a reviewer to PR #537.

@HaidaoLin-NOAA
Copy link
Contributor

HaidaoLin-NOAA commented Feb 21, 2023 via email

@RussTreadon-NOAA
Copy link
Contributor

OK. Thank you @HaidaoLin-NOAA for letting us know.

DavidHuber-NOAA added a commit to DavidHuber-NOAA/GSI that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants