Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in EnKF assim of conventional q obs #544

Closed
ClaraDraper-NOAA opened this issue Feb 23, 2023 · 1 comment
Closed

Bugfix in EnKF assim of conventional q obs #544

ClaraDraper-NOAA opened this issue Feb 23, 2023 · 1 comment

Comments

@ClaraDraper-NOAA
Copy link
Contributor

ClaraDraper-NOAA commented Feb 23, 2023 •
edited
Loading

For the EnKF, the analysis variable is q/qsat. In readconvobs.f90 for q obs, the obs, obs error, and hofx are also all q/qsat. However hx_modens is not divided by qsat, and is consequently much smaller than it should be.

When assimilating conventional q obs with the EnKF, we currently do not get significant increments due to this bug. Fixing this bug generates increments of the expected magnitude.

The impact of the bugfix is moderate over land near the surface. For details:

https://drive.google.com/file/d/19TRrygaR5g2iJ2xMmthfHzxrCCf61TeR/view?usp=sharing

Note that this bug only occurs if using model vertical localization and linearised hofx.
@ClaraDraper-NOAA ClaraDraper-NOAA mentioned this issue Feb 23, 2023
Merged
1 task
CoryMartin-NOAA pushed a commit that referenced this issue Mar 2, 2023
@ClaraDraper-NOAA
Bugfix in EnKF assim of conventional q obs (#545)
df010e4 
**Description**

Added code to divide hx_modens by qsat, for consistency with treatment
of q as q/qsat.

Fixes issue #544
RussTreadon-NOAA added a commit to RussTreadon-NOAA/GSI that referenced this issue Mar 28, 2023
@RussTreadon-NOAA
use prod ncio and ncdiag on wcoss2 (NOAA-EMC#544)
5767056
@ClaraDraper-NOAA
Copy link
Contributor Author

Closing, as PR with bug fix was merged.

TingLei-daprediction pushed a commit to TingLei-daprediction/GSI that referenced this issue May 23, 2023
@ClaraDraper-NOAA @TingLei-daprediction
Bugfix in EnKF assim of conventional q obs (NOAA-EMC#545)
54c2f52 
**Description**

Added code to divide hx_modens by qsat, for consistency with treatment
of q as q/qsat.

Fixes issue NOAA-EMC#544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ClaraDraper-NOAA