Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined values found in radar reflectivity direct DA #604

Closed
shoyokota opened this issue Aug 4, 2023 · 0 comments · Fixed by #605
Closed

Undefined values found in radar reflectivity direct DA #604

shoyokota opened this issue Aug 4, 2023 · 0 comments · Fixed by #605

Comments

@shoyokota
Copy link
Collaborator

Some undefined values are found in the radar reflectivity direct DA (if_model_dbz=T and l_use_dbz_directDA=F) in RRFS with the debug option. They should be fixed to be able to run with the debug option.

shoyokota pushed a commit to shoyokota/GSI that referenced this issue Aug 4, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Aug 9, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Aug 11, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Aug 16, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Aug 29, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 9, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 9, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 11, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 18, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 29, 2023
shoyokota pushed a commit to shoyokota/GSI that referenced this issue Sep 29, 2023
ShunLiu-NOAA pushed a commit that referenced this issue Sep 30, 2023
… DA (#605)

**Description**

To prevent some undefined values found in the radar reflectivity direct
DA (if_model_dbz=T and l_use_dbz_directDA=F), corresponding parts are
fixed. It doesn't change the result except for the case of the execution
with the debug option.

Fixes #604

**Type of change**

- [x] Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested?**

The radar reflectivity DA test with the RRFS setting was done on Orion.
After this modification, EnVar was completed even with the debug option.
This modification didn't change the result in the test without the debug
option.
  
**Checklist**

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] New and existing tests pass with my changes
- [x] Any dependent changes have been merged and published

**Due date for this PR is 9/15/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.

Co-authored-by: Sho Yokota <syokota@Orion-login-2.HPC.MsState.Edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant