Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative sphum and hydrometeors from RRFS GSI #680

Closed
AmandaBack-NOAA opened this issue Jan 9, 2024 · 0 comments · Fixed by #682
Closed

Negative sphum and hydrometeors from RRFS GSI #680

AmandaBack-NOAA opened this issue Jan 9, 2024 · 0 comments · Fixed by #682
Assignees
@AmandaBack-NOAA

Comments

@AmandaBack-NOAA
Copy link
Contributor

In the RRFS workflow, after the anal_gsi_input task runs, the specific humidity field ("sphum") in the fv_tracer INPUT NetCDF file contains negative values. After hybrid_radar_ref GSI runs, there are also negative values in the hydrometeors ice_wat, liq_wat, rainwat, snowwat, and graupel. None of these variables can physically be negative.
@JacobCarley-NOAA JacobCarley-NOAA mentioned this issue Jan 9, 2024
Open
@AmandaBack-NOAA AmandaBack-NOAA mentioned this issue Jan 11, 2024
Merged
6 tasks
ShunLiu-NOAA pushed a commit that referenced this issue Jan 24, 2024
@AmandaBack-NOAA
add clipping treatment for negative values of non-negative tracers (#682
12f8d3e 
)

**Description**

Clips negative values from fields in the tracer file before writing.
Fixes #680.


**Type of change**

- [ ] Bug fix (non-breaking change which fixes an issue)


**How Has This Been Tested?**

Tested on Hera in a RRFS CONUS workflow with both hybrid_radar_ref and
anal_gsi_input tasks.
See run directory at /scratch2/BMC/zrtrr/aback/hydrometeors_test/
For one hour of the control run without this change, and one hour using
the change contained in this PR, the INPUT directory was saved for
reference/rerunning before each of the tasks: anal_gsi_input_spinup,
hybrid_radar_ref_spinup, cldanl_nonvar_spinup, and run_fcst spinup.
Those directories are at, for example
/scratch2/BMC/zrtrr/aback/hydrometeors_test/INPUT_after_anal_gsi_input_spinup_before_hybrid_radar_ref_spinup
("control") and
/scratch2/BMC/zrtrr/aback/hydrometeors_test/clipped_INPUT_after_anal_gsi_input_spinup_before_hybrid_radar_ref_spinup
(using the code in the PR).
Logs are at
/scratch2/BMC/zrtrr/aback/hydrometeors_test/v0.7.9/logs/rrfs.20230610/08/,
including new logs produced between all the above-listed tasks, showing
all the min and max values in fv_tracer.

  
**Checklist**

The code is Ting Lei's. It looks stylish and understandable to me
(Amanda) but maybe Ting should weigh in on this section.
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] New and existing tests pass with my changes
- [ ] Any dependent changes have been merged and published

**DUE DATE for merger of this PR into `develop` is 2/22/2024 (six weeks
after PR creation).**

---------

Co-authored-by: Ting.Lei-NOAA <ting.lei@dlogin09.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmandaBack-NOAA AmandaBack-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add clipping treatment for negative values of non-negative tracers TingLei-NOAA/GSI
1 participant
@AmandaBack-NOAA