Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix needed for mismatch dimensions of parameters in netcdf IO for fv3reg GSI #693

Closed
TingLei-NOAA opened this issue Feb 9, 2024 · 0 comments · Fixed by #698
Closed
Assignees

Comments

@TingLei-NOAA
Copy link
Contributor

In the current fv3reg GSI, the location /size parameters in netcdf sub calls as startloc and countloc below :

iret=nf90_get_var(gfile_loc,var_id,uu2d,start=startloc,count=countloc)

are defined as 3D arrays while ignore the fourth time dimension of the actual netcdf variables. This treatment had been working (for example, passed verification by original non-parallel version). However @edwardhartnett pointed out it is wrong and, at least, potentially, could cause unexpected behavior.
Hence, a quick fix to increase those parameters to 4d arrays are needed.

ShunLiu-NOAA pushed a commit that referenced this issue Mar 20, 2024
…SI failure … (#698)

**DUE DATE for merger of this PR into `develop` is 3/27/2024 (six weeks
after PR creation).**

Resolves #693 (Thanks to @edwardhartnett 's suggestions)
Resolves # 694 ( this PR is not able to provide a stable solution, more
details would be given on the issue page)
Resolves # 697: With larger requested memory for each mpi task, it still
showed, for some time, the differences in the analysis files between
loproc vs hiproc for the control runs on hercules. whether integrating
this with the refactored IO part would provide a stable solution remains
to be seen.

This PR resolved the newly emerged issue with IO of netcdf files in the
continuous storage, with upgraded FV3REG IO for the cold start options.
(Co author Ming Hu @hu5970 )
This PR is being worked on in collaboration with Pete Johnson through
RDHPCS help desk, @RussTreadon-NOAA @DavidHuber-NOAA and thanks to help
from @ed Raghue Reddy through RDHPCS help desk.

---------

Co-authored-by: Ting Lei <tlei@hercules-login-4.hpc.msstate.edu>
Co-authored-by: Ting.Lei-NOAA <ting.lei@dlogin08.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant