Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#268. Port the ConMon to S4 and Jet #274

Merged

Conversation

DavidHuber-NOAA
Copy link
Collaborator

This ports the ConMon to S4 and Jet and also fixes a few bugs as referenced in #268. The bug fixes include:

  • Removing a duplicate compression step from plot_horz.sh (retaining plot_horz_uv.sh) and increasing requested wall times for plot_horz_uv.sh
  • Modifying the naming convention of the plot_horz_uv GrADS control files to match the other control files.
  • Minor bug fixes to GrADS scripts (plot_hist.gs, plot_tallev_horz.gs, plot_uvallev_horz.gs, and plot_uvsatwind_horz.gs)

@DavidHuber-NOAA
Copy link
Collaborator Author

I would appreciate a review from @EdwardSafford-NOAA who tested this on WCOSS and Hera.

Copy link
Contributor

@EdwardSafford-NOAA EdwardSafford-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks again for cleaning up the bugs.

@MichaelLueken MichaelLueken self-requested a review January 5, 2022 14:34
@MichaelLueken MichaelLueken linked an issue Jan 5, 2022 that may be closed by this pull request
@MichaelLueken
Copy link
Contributor

Since there are no source code changes and @EdwardSafford-NOAA has approved the changes, I will now give final approval to these changes and merge them to the authoritative repository.

@MichaelLueken MichaelLueken changed the title Port the ConMon to S4 and Jet GitHub Issue NOAA-EMC/GSI#268. Port the ConMon to S4 and Jet Jan 5, 2022
@MichaelLueken MichaelLueken merged commit 40deca7 into NOAA-EMC:master Jan 5, 2022
@DavidHuber-NOAA DavidHuber-NOAA deleted the port_conmon_2_jet_s4 branch February 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port the ConMon to S4 and Jet
3 participants