GitHub Issue NOAA-EMC/GSI#320. Replaced fv3gfs_ncio with hpc-stack built ncio. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerorahul
reviewed
Mar 21, 2022
…ncio. * all CMakeLists.txt entries that use fv3gfs_ncio - updated to use hpc-stack built ncio library * cmake/Modules/setGNUFlags.cmake - remove fv3gfs_ncio flags * cmake/Modules/setIntelFlags.cmake - same * hpc-stack compliant modulefiles - add module load ncio/1.0.0 * src/fv3gfs_ncio - removed * all *90 which currently use module_fv3gfs_ncio - replace module_fv3gfs_ncio with module_ncio * ush/sub_hera - corrected issue that would cause regression tests to fail on Hera due to SLURM out-of-memory issues
MichaelLueken
force-pushed
the
feature/fv3gfs_ncio-removal
branch
from
b02ffbc
to
2db5d3c
Compare
|
Thank you very much for the review @aerorahul! Also, thanks for pointing out the BUILD_FV3GFS_NCIO entry I missed in CMakeLists.txt. This has been removed at 2db5d3c. |
|
This update is needed, along with NOAA-EMC/NCEPLIBS-ncio#53, for GSI to work with the latest ufs-weather-model/develop. See #348 |
|
This PR will now be closed. PR #327 includes this work, so there is no need to move forward with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression tests were run on WCOSS and Hera and all passed successfully.
Closes #320