Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue NOAA-EMC/GSI#417. Add continuous integration build tests for Intel and GNU compilers. #418

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jun 22, 2022

This PR:

  • adds 2 github actions CI files .github/workflows/gcc.yml and .github/workflows/intel.yml. These actions build the GSI, EnKF and the utilities using the GCC and Intel compiler suite respectively.
  • The suites are built and cached to be used in subsequent builds thus saving time and resources.
  • The suites and dependencies are built using Spack
  • The dependencies are stored in ci/spack.yaml

Closes #417

Once merged, one can track the Actions for e.g see the push action for this PR at https://github.com/aerorahul/GSI/actions

@MichaelLueken
Copy link
Contributor

@aerorahul - I'm fine with moving forward with this update. However, you will need to reduce the number of commits from 12 to 1 and ensure that you add NOAA-EMC#417 to the final commit message. You can do these by:

  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git commit --amend
  • Please add NOAA-EMC#417 at this point.
  • git push origin feature/ci --force

@aerorahul
Copy link
Contributor Author

@aerorahul - I'm fine with moving forward with this update. However, you will need to reduce the number of commits from 12 to 1 and ensure that you add NOAA-EMC#417 to the final commit message. You can do these by:

  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git reset --soft HEAD~1
  • git commit --amend
  • Please add NOAA-EMC#417 at this point.
  • git push origin feature/ci --force

done.

@MichaelLueken
Copy link
Contributor

@aerorahul Thanks! I will now move forward with adding continuous integration build test for Intel and GNU compilers to the authoritative repository.

@MichaelLueken MichaelLueken changed the title Add continuous integration build tests for Intel and GNU compilers. GitHub Issue NOAA-EMC/GSI#417. Add continuous integration build tests for Intel and GNU compilers. Jun 22, 2022
@MichaelLueken
Copy link
Contributor

Since there are no changes to the source code and do not affect results, I will give final approval to these changes and merge them to the authoritative develop branch.

@MichaelLueken MichaelLueken merged commit 483ff97 into NOAA-EMC:develop Jun 22, 2022
@aerorahul aerorahul deleted the feature/ci branch July 8, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup continuous integration with every push and pull request
2 participants