update fix submodule to bring in gfs.v16.3.7 changes

[RussTreadon-NOAA]

Description
This PR is opened to address two items related to GFS v16.3.7. This implementation modified GSI fix file global_convinfo.txt.

1. EIB updated their staged GSI fix files to be consistent with GFS v16.3.7. This PR updates the path to the EIB staged files, GSI_BINARY_SOURCE_DIR in GSI modulefiles.
2. The updated global_convinfo.txt was committed to NOAA-EMC/GSI-fix at 6a42a29. The fix submodule in NOAA-EMC/GSI needs to be updated to point at this GSI-fix hash. This PR updates the fix submodule hash.

fixes #580

Type of change

• Maintenance

How Has This Been Tested?
RussTreadon:feature/gsifix was cloned on WCOSS2 (cactus). File global_convinfo.txt was compared with /lfs/h1/ops/prod/packages/gfs.v16.3.7/fix/fix_gsi/global_convinfo.txt. The two files are identical.

/ush/build.sh was executed in the Cactus working copy of feature/gsifix. The correct binary GSI fix files were copied from the updated EIB path.

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• New and existing tests pass with my changes

DUE DATE for merger of this PR into develop is 7/5/2023 (six weeks after PR creation).

[RussTreadon-NOAA]

Regression (ctests) tests
Standard suite of 9 regression (ctests) run on WCOSS2 (Cactus), Hera, and Orion. See #580 for detailed ctest reporting.

All tests pass except netcdf_fv3_regional. This is a known problem. PR #570 fixes this failure.

[RussTreadon-NOAA]

WCOSS2 (Cactus) real-time test

This PR changes one fix file, global_convinfo.txt via the updated GSI-fix hash. Run the operational 2023052500 gdas case on Cactus three times using a stand-alone rungsi script. The first run used gsi.x and fix/ from develop. The second run used gsi.x from gsifix and fix/ from develop. The third run used gsi.x from gsifix and fix/ from gsifix.

The first and second runs, those using the same fix/ from develop, generate identical analysis results. This is expected. This PR does not change gsi source code.

The third run differs from the first two in the uv stats. When using the gsifix fix/ the following wind types are assimilated in the third run

• uv 243 0057
• uv 253 0057
• uv 254 0057

This is an expected result. This PR updates the GSI-fix hash so that global_convinfo.txt is consistent with the operational GFS v16.3.7. The operational gdas for 2023052500 assimilates uv data for these types and satellite.

[CatherineThomas-NOAA]

EIB updated their staged GSI fix files to be consistent with GFS v16.3.7.

Looking at the staged global_convinfo files on Hera and Orion, I don't see the changes to the AMVs:

/scratch1/NCEPDEV/global/glopara/fix/gsi/20230112/global_convinfo.txt
 uv       254   57   -1     3.0      0      0      0   1.5  20.0   1.4   1.5  0.050500     1  200.   100.      0    0.     2.   15   -8

/work/noaa/global/glopara/fix/gsi/20230112/global_convinfo.txt
 uv       254   57   -1     3.0      0      0      0   1.5  20.0   1.4   1.5  0.050500     1  200.   100.      0    0.     2.   15   -8

[RussTreadon-NOAA]

@KateFriedman-NOAA , @WalterKolczynski-NOAA , @emilyhcliu , and @ADCollard :

@CatherineThomas-NOAA found that global_convinfo.txt in the recently updated GSI_BINARY_SOURCE_DIR differs from the operational GFS v16.3.7.

The operational GFS v16.3.7 global_convinfo.txt turned on assimilation of Meteosat-10 AMVs. This PR points GSI develop at a GSI-fix hash with the operational global_convinfo.txt. In contrast, the 20230112 update to GSI_BINARY_SOURCE_DIR has Meteosat-10 AMVs in monitor mode. We should update global_convinfo.txt in GSI_BINARY_SOURCE_DIR.

Here are the GSI_BINARY_SOURCE_DIR on various machines

• Hera: /scratch1/NCEPDEV/global/glopara/fix/gsi/20230112
• Jet: /mnt/lfs4/HFIP/hfv3gfs/glopara/git/fv3gfs/fix/gsi/20230112
• Orion: /work/noaa/global/glopara/fix/gsi/20230112
• S4: /data/prod/glopara/fix/gsi/20230112
• WCOSS2: /lfs/h2/emc/global/noscrub/emc.global/FIX/fix/gsi/20230112

If we do not want to replace global_convinfo.txt in .../fix/gsi/20230112, we need a new .../fix/gsi/YYYYMMDD directory. I recommend updating global_convinfo.txt in the existing GSI_BINARY_SOURCE_DIR listed above.

[RussTreadon-NOAA]

Note: This PR can not move forward until action is taken on g-w issue #1650.

[RussTreadon-NOAA]

@CatherineThomas-NOAA , a new GSI_BINARY_SOURCE_DIR with the date 20230601 has been created by EIB containing the updated global_convinfo.txt. The EIB staged fix files in the 20230601 directory are identical to the contents of fix/ from this PR after executing ush/build.sh apart from .git

Hera

Hera(hfe04):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr581$ diff -r fix /scratch1/NCEPDEV/global/glopara/fix/gsi/20230601
File fix/.git is a regular file while file /scratch1/NCEPDEV/global/glopara/fix/gsi/20230601/.git is a directory
Hera(hfe04):/scratch1/NCEPDEV/da/Russ.Treadon/git/gsi/pr581$

Orion

Orion-login-1:/work2/noaa/da/rtreadon/git/gsi/pr581$ diff -r fix/ /work/noaa/global/glopara/fix/gsi/20230601/
File fix/.git is a regular file while file /work/noaa/global/glopara/fix/gsi/20230601/.git is a directory
Orion-login-1:/work2/noaa/da/rtreadon/git/gsi/pr581$

WCOSS2 (Dogwood)

russ.treadon@dlogin08:/lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/pr581> diff -r fix/ /lfs/h2/emc/global/noscrub/emc.global/FIX/fix/gsi/20230601/
File fix/.git is a regular file while file /lfs/h2/emc/global/noscrub/emc.global/FIX/fix/gsi/20230601/.git is a directory
russ.treadon@dlogin08:/lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/pr581> 

[RussTreadon-NOAA]

Regression tests have been run on Hera, Orion, and WCOSS2 (see issue #580) with acceptable results. This PR is ready for review.

[RussTreadon-NOAA]

@CatherineThomas-NOAA and @ADCollard , g-w issue #1650 lists 7 remaining steps to fully bring the GFS v16.3.7 global_convinfo.txt into g-w develop. Approval of this PR is the first of these remaining steps. Your review of this PR sometime this week is much appreciated. Thank you!

[RussTreadon-NOAA]

Reach out to Handling Review Team. Consensus that this PR is ready for merger into develop. Will move forward with merger.