-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gsi fed #590
Merged
Merged
Gsi fed #590
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a95d8ec
Trying to add new FED observation operator.
daviddowellNOAA 0c2780e
updates for adding FED observations and observation operator to GSI o…
daviddowellNOAA a54b475
updates to add FED observations and observation operator to GSI observer
daviddowellNOAA f9433d8
Updated code, with changes suggested by reviewers.
daviddowellNOAA d3e64d3
Bug fix requested by Guoqing Ge and Chunhua Zhou.
daviddowellNOAA e3fb49b
Merge remote-tracking branch 'emc/develop' into GSI_FED
daviddowellNOAA c498c47
Merge branch 'develop' into GSI_FED
hu5970 278ee2f
Clean read_fed.f90 and setupfed.f90: remove unused variables found by…
hu5970 57ae9ac
Add boundary check for lat and lon.
hu5970 7b659e9
Merge pull request #1 from hu5970/GSI_FED2
daviddowellNOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| module gsi_fedOper | ||
| !$$$ subprogram documentation block | ||
| ! . . . . | ||
| ! subprogram: module gsi_fedOper | ||
| ! | ||
| ! abstract: an obOper extension for fedNode type | ||
| ! | ||
| ! program history log: | ||
| ! 2023-07-10 D. Dowell - created new module for FED (flash extent | ||
| ! density); gsi_dbzOper.F90 code used as a | ||
| ! starting point for developing this new module | ||
| ! | ||
| ! input argument list: see Fortran 90 style document below | ||
| ! | ||
| ! output argument list: see Fortran 90 style document below | ||
| ! | ||
| ! attributes: | ||
| ! language: Fortran 90 and/or above | ||
| ! machine: | ||
| ! | ||
| !$$$ end subprogram documentation block | ||
|
|
||
| ! module interface: | ||
|
|
||
| use gsi_obOper, only: obOper | ||
| use m_fedNode , only: fedNode | ||
| implicit none | ||
| public:: fedOper ! data structure | ||
| public:: diag_fed | ||
|
|
||
| type,extends(obOper):: fedOper | ||
| contains | ||
| procedure,nopass:: mytype | ||
| procedure,nopass:: nodeMold | ||
| procedure:: setup_ | ||
| procedure:: intjo1_ | ||
| procedure:: stpjo1_ | ||
| end type fedOper | ||
|
|
||
| ! def diag_fed- namelist logical to compute/write (=true) FED diag files | ||
| logical,save:: diag_fed=.false. | ||
|
|
||
| !~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| character(len=*),parameter :: myname='gsi_fedOper' | ||
| type(fedNode),save,target:: myNodeMold_ | ||
|
|
||
| contains | ||
| function mytype(nodetype) | ||
| implicit none | ||
| character(len=:),allocatable:: mytype | ||
| logical,optional, intent(in):: nodetype | ||
| mytype="[fedOper]" | ||
| if(present(nodetype)) then | ||
| if(nodetype) mytype=myNodeMold_%mytype() | ||
| endif | ||
| end function mytype | ||
|
|
||
| function nodeMold() | ||
| !> %nodeMold() returns a mold of its corresponding obsNode | ||
| use m_obsNode, only: obsNode | ||
| implicit none | ||
| class(obsNode),pointer:: nodeMold | ||
| nodeMold => myNodeMold_ | ||
| end function nodeMold | ||
|
|
||
| subroutine setup_(self, lunin, mype, is, nobs, init_pass, last_pass) | ||
| use fed_setup, only: setup | ||
| use kinds, only: i_kind | ||
| use gsi_obOper, only: len_obstype | ||
| use gsi_obOper, only: len_isis | ||
|
|
||
| use m_rhs , only: awork => rhs_awork | ||
| use m_rhs , only: bwork => rhs_bwork | ||
| use m_rhs , only: iwork => i_fed | ||
|
|
||
| use obsmod , only: write_diag | ||
| use jfunc , only: jiter | ||
|
|
||
| use mpeu_util, only: die | ||
|
|
||
| use obsmod, only: dirname, ianldate | ||
|
|
||
| implicit none | ||
| class(fedOper ), intent(inout):: self | ||
| integer(i_kind), intent(in):: lunin | ||
| integer(i_kind), intent(in):: mype | ||
| integer(i_kind), intent(in):: is | ||
| integer(i_kind), intent(in):: nobs | ||
| logical , intent(in):: init_pass ! supporting multi-pass setup() | ||
| logical , intent(in):: last_pass ! with incremental backgrounds. | ||
|
|
||
| !---------------------------------------- | ||
| character(len=*),parameter:: myname_=myname//"::setup_" | ||
|
|
||
| character(len=len_obstype):: obstype | ||
| character(len=len_isis ):: isis | ||
| integer(i_kind):: nreal,nchanl,ier,nele | ||
| logical:: diagsave | ||
| integer(i_kind):: lu_diag | ||
| character(128):: diag_file | ||
| character(80):: string | ||
|
|
||
| if(nobs == 0) then | ||
|
|
||
| if( (mype == 0) .and. init_pass ) then | ||
| write(string,600) jiter | ||
| 600 format('fed_',i2.2) | ||
| diag_file=trim(dirname) // trim(string) | ||
| write(6,*) 'write ianldate to ', diag_file | ||
| open(newunit=lu_diag,file=trim(diag_file),form='unformatted',status='unknown',position='rewind') | ||
| write(lu_diag) ianldate | ||
| close(lu_diag) | ||
| endif | ||
|
|
||
| return | ||
|
|
||
| endif | ||
|
|
||
| read(lunin,iostat=ier) obstype,isis,nreal,nchanl | ||
| if(ier/=0) call die(myname_,'read(obstype,...), iostat =',ier) | ||
| nele = nreal+nchanl | ||
|
|
||
| diagsave = write_diag(jiter) .and. diag_fed | ||
|
|
||
| call setup(self%obsLL(:), self%odiagLL(:), & | ||
| lunin,mype,bwork,awork(:,iwork),nele,nobs,is,diagsave,init_pass) | ||
|
|
||
| end subroutine setup_ | ||
|
|
||
| subroutine intjo1_(self, ibin, rval,sval, qpred,sbias) | ||
| use gsi_bundlemod , only: gsi_bundle | ||
| use bias_predictors, only: predictors | ||
| use m_obsNode , only: obsNode | ||
| use m_obsLList, only: obsLList_headNode | ||
| use kinds , only: i_kind, r_quad | ||
| implicit none | ||
| class(fedOper ),intent(in ):: self | ||
| integer(i_kind ),intent(in ):: ibin | ||
| type(gsi_bundle),intent(inout):: rval ! (ibin) | ||
| type(gsi_bundle),intent(in ):: sval ! (ibin) | ||
| real(r_quad ),target,dimension(:),intent(inout):: qpred ! (ibin) | ||
| type(predictors),target, intent(in ):: sbias | ||
|
|
||
| !---------------------------------------- | ||
| character(len=*),parameter:: myname_=myname//"::intjo1_" | ||
| class(obsNode),pointer:: headNode | ||
|
|
||
| end subroutine intjo1_ | ||
|
|
||
| subroutine stpjo1_(self, ibin, dval,xval,pbcjo,sges,nstep,dbias,xbias) | ||
| use gsi_bundlemod, only: gsi_bundle | ||
| use bias_predictors, only: predictors | ||
| use m_obsNode , only: obsNode | ||
| use m_obsLList, only: obsLList_headNode | ||
| use kinds, only: r_quad,r_kind,i_kind | ||
| implicit none | ||
| class(fedOper ),intent(in):: self | ||
| integer(i_kind ),intent(in):: ibin | ||
| type(gsi_bundle),intent(in):: dval | ||
| type(gsi_bundle),intent(in):: xval | ||
| real(r_quad ),dimension(:),intent(inout):: pbcjo ! (1:4) | ||
| real(r_kind ),dimension(:),intent(in ):: sges | ||
| integer(i_kind),intent(in):: nstep | ||
|
|
||
| type(predictors),target, intent(in):: dbias | ||
| type(predictors),target, intent(in):: xbias | ||
|
|
||
| !---------------------------------------- | ||
| character(len=*),parameter:: myname_=myname//"::stpjo1_" | ||
| class(obsNode),pointer:: headNode | ||
|
|
||
| end subroutine stpjo1_ | ||
|
|
||
| end module gsi_fedOper | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 3-8: Is Guo involved in the development of this gsi_fedOper.f90 file? If not, suggest removing these lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not involved. I will update the documentation accordingly.