Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing jacobian arrays to netcdf ozone diagnostic file (#618) #619

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Sep 9, 2023

Description
PR #591 removed jacobian information from the netcdf ozone diagnostic file. This caused enkf.x to crash. This PR adds the removed ozone jacobian arrays back to the netcdf ozone diagnostic file.

Fixes #618

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
The revised code was tested in the 20210814 18 gdas cycle of a C192L127 enkf parallel. The updated gsi.x created an oznstat file which was successfully processed by enkf.x.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Sep 9, 2023
@RussTreadon-NOAA
Copy link
Contributor Author

Ctests
Run ctests on Orion, Hera, and WCOSS2 (Dogwood). Results are acceptable on all three platforms. No fatal fails occurred. Details are posted here in issue #618.

@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Sep 11, 2023

Cycled test using RussTreadon-NOAA:feature/oznstat gsi.x in eobs allows enkf.x to run to completion but the resulting analysis increments are not physical. See comments in #618.

Additional changes appear to be needed in setupoz.f90 and/or the enkf code which reads the ozone netcdf diagnostic file.

@RussTreadon-NOAA
Copy link
Contributor Author

Hera and Orion cycled tests of eobs, ediag, and eupd generate expected results. feature/oznstat reproduces results from the GSI hash prior to PR #591.

The standard suite of ctests on Hera, Orion, and WCOSS2 either pass or generate a non-fatal fail.

The changes in this PR are ready for peer review.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review September 11, 2023 23:52
Copy link
Contributor

@HaixiaLiu-NOAA HaixiaLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look good to me.

@HaixiaLiu-NOAA
Copy link
Contributor

@RussTreadon-NOAA Thank you for testing the changes and confirming that the results are reproduced.

@RussTreadon-NOAA
Copy link
Contributor Author

@jack-woollen , if you have time would you look at the changes in this PR? If the changes look good to you, an approval from you along with Haixia is sufficient for me to pass this PR onto a member of the GSI Handling Review team for merger into develop. Once this PR is in GSI develop, I'll open a g-w PR to update the GSI hash cloned by g-w.

Copy link
Contributor

@jack-woollen jack-woollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks okay to me too. Thanks for testing it thoroughly.

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @jack-woollen and @HaixiaLiu-NOAA for your reviews and approvals!

@RussTreadon-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA , would you be willing to be the Handling reviewer for this PR? I can't approve and merge this PR into develop since I opened the PR.

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycling tests on Hera/Orion work as expected, regression tests pass on those platforms + WCOSS2. Changes look good to me. Thank you @RussTreadon-NOAA

@CoryMartin-NOAA CoryMartin-NOAA merged commit a6515bd into NOAA-EMC:develop Sep 12, 2023
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/oznstat branch September 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables missing from ozone diagnostic files
4 participants