Update read_ozone.f90 to handle GOME data before and after 20240131 18Z #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ctests have been run on Cactus, Hera, Hercules, and Orion with acceptable results. See issue #716 for details. |
HaixiaLiu-NOAA
approved these changes
Mar 17, 2024
|
@RussTreadon-NOAA Thank you for making the changes. |
BrettHoover-NOAA
approved these changes
Mar 18, 2024
|
@ShunLiu-NOAA , @hu5970 , and @CoryMartin-NOAA : This PR has been peer reviewed and approved. ctests have been run on WCOSS2 (Cactus), Hera, Hercules, and Orion with acceptable results. Additionally debug global_4denvar tests have been successfully run on Cactus using old and new GOME format bufr files. This PR is ready for merger into |
|
Russ,
Works for me.
Shun
…On Mon, Mar 18, 2024 at 2:56 PM RussTreadon-NOAA ***@***.***> wrote:
@ShunLiu-NOAA <https://github.com/ShunLiu-NOAA> , @hu5970
<https://github.com/hu5970> , and @CoryMartin-NOAA
<https://github.com/CoryMartin-NOAA> : This PR has been peer reviewed and
approved. ctests have been run on WCOSS2 (Cactus), Hera, Hercules, and
Orion with acceptable results. Additionally debug global_4denvar tests have
been successfully run on Cactus using old and new GOME format bufr files.
This PR is ready for merger into develop.
—
Reply to this email directly, view it on GitHub
<#721 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACD5GZY34XJSDH4TN2426E3YY42FDAVCNFSM6AAAAABEYJ4QKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGY4TKOBYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Me too, approve and merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The contents of the GOME bufr dump file changed 20240131 18Z. The
DOYRmnenoic was replaced withMNTH DAYS. This PR is opened to get the required changes toread_ozone.f90intodevelop.This change is required because NCO IT testing compiles and runs executables in debug mode. At present
gsi.xbuilt fromdevelopwill abort with forrtl: error (65): floating invalid when processing GOME data. This is not acceptable. The debuggsi.xmust successfully run to completion.Fixes #716
Type of change
How Has This Been Tested?
The updated
read_ozone.f90has been used in the global_4denvar ctest for two dates: 20221109 00Z (old GOME bufr format) and 20240223 00Z (new GOME bufr format).gsi.xwas built in debug mode and run for both cases.gsi.xsuccessfully ran to completion for both cases.Checklist