ECMWF GRIB Decode Success with new AEC/CCSDS Library? #461
Assignees
Labels
question
Further information is requested
Comments
JKrobNESDIS
changed the title
|
Hi @JKrobNESDIS, can you pass along or point me to the ECMWF GRIB2 files you are working with? Even if just 1 message from the file? |
|
@JKrobNESDIS I quickly read earlier and did not notice the link. I will download a file and take a look. |
|
I have been looking at this over the last couple of days. I can confirm that this is a bug in the implementation of the AEC compression in the g2c library. I have identified the bug and am working a fix immediately. @edhartnett would we be able to issue a v1.8.1 patch release? |
Merged
21 tasks
|
We can do a new release if you need it. |
|
Edward, Eric,
I've been following this thread & am I correct to presume the issue has
been fixed & the ECMWF GRIB data processes correctly? Because I put Eric's
changes in 'aecunpack.c' into my code...and still get the same errors
returned...just checking.
Thanks,
Jeff
…On Fri, Dec 15, 2023 at 8:29 AM Edward Hartnett ***@***.***> wrote:
We can do a new release if you need it.
—
Reply to this email directly, view it on GitHub
<#461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBCEF7EIY72GUAIIFEN655DYJRGB3AVCNFSM6AAAAABACU7DOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJXHA4DGNBZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @JKrobNESDIS. Would you be willing to share your code? Or least the portion that does the ECMWF GRIB2 reading/unpacking using g2c? |
|
Hey Eric,
How would I go about doing that without posting on GitHub?
Jeff
…On Sun, Dec 17, 2023 at 11:01 AM Eric Engle ***@***.***> wrote:
Hi @JKrobNESDIS <https://github.com/JKrobNESDIS>. Would you be willing to
share your code? Or least the portion that does the ECMWF GRIB2
reading/unpacking using g2c?
—
Reply to this email directly, view it on GitHub
<#461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBCEF7HKZEVFAJ3PXU4BL2LYJ4JODAVCNFSM6AAAAABACU7DOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGIYTAMJUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Feel free to share with me via NOAA email or through the NOAA Google Drive. |
edwardhartnett
pushed a commit
that referenced
this issue
Dec 20, 2023
* Update for aecunpack.c This commit fixes a bug in aecunpack.c where the bytes from the decoded AEC buffer stream are not being properly copied into the ifld array. The AEC stream is byte aligned. This commit references #461 * Update aecunpack.c Commenting out ifld1 since the code logic that uses it is commented out. This commit references #461 --------- Co-authored-by: Eric Engle <EricEngle-NOAA@users.noreply.github.com>
|
Should this issue be closed? |
|
Hey Edward,
I have yet to get it to work for me with GRIB data from ECMWF. Every GRIB
message processed consistently fails in the 'aec_decode' function. Since C
is not my 'native language', I have no idea what the issue is. I was
working with Eric Engle back in December with the issue...but it kinda fell
by the wayside :-/ I don't know if anyone else has had success with this
libaec library processing the ECMWF GRIB.
Thanks,
Jeff
…On Mon, Jun 17, 2024 at 2:58 AM Edward Hartnett ***@***.***> wrote:
Should this issue be closed?
—
Reply to this email directly, view it on GitHub
<#461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBCEF7B7RT4BYWABDGGLOI3ZH2CHZAVCNFSM6AAAAABJNMN7VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGQ2DCNBQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Edward,
Details from above:
In function 'int aec_decode', the following 'do' loop is reporting an
'M_ERROR'
do {
status = state->mode(strm);
} while (status == M_CONTINUE);
Jeff
On Mon, Jun 17, 2024 at 5:35 AM Jeffrey Krob - NOAA Federal <
***@***.***> wrote:
… Hey Edward,
I have yet to get it to work for me with GRIB data from ECMWF. Every GRIB
message processed consistently fails in the 'aec_decode' function. Since C
is not my 'native language', I have no idea what the issue is. I was
working with Eric Engle back in December with the issue...but it kinda fell
by the wayside :-/ I don't know if anyone else has had success with this
libaec library processing the ECMWF GRIB.
Thanks,
Jeff
On Mon, Jun 17, 2024 at 2:58 AM Edward Hartnett ***@***.***>
wrote:
> Should this issue be closed?
>
> —
> Reply to this email directly, view it on GitHub
> <#461 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BBCEF7B7RT4BYWABDGGLOI3ZH2CHZAVCNFSM6AAAAABJNMN7VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGQ2DCNBQGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
I will try to devote some time to this in the next couple of weeks. We are spinning up development on NBM v5.0. |
|
Sounds great, thanks for the update! I appreciate the help.
Jeff
…On Mon, Jun 17, 2024 at 8:00 AM Eric Engle ***@***.***> wrote:
I will try to devote some time to this in the next couple of weeks. We
spinning up development on NBM v5.0.
—
Reply to this email directly, view it on GitHub
<#461 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBCEF7BQITIXGTMQU733N3TZH3FTXAVCNFSM6AAAAABJNMN7VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGE4TMNZRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All,
With the release of the new AEC/CCSDS Decode Library, I have been trying to decode the public ECMWF GRIB data...with no success.
https://data.ecmwf.int/forecasts/
Function m_split in 'decode.c' keeps responding with "return M_ERROR - 5"
I'm calling g2c_aecunpackf from the fortran gf_unpack.f & I can see all my arguments are passed intact so....
If someone could test out the ECMWF GRIB from the pure C routines to confirm/deny whether it works correctly would be most helpful.
Thanks in advance,
Jeff Krob
NOAA/NESDIS
The text was updated successfully, but these errors were encountered: