Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDASApp to use git submodules + Rocky 8 for Hera #11

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

CoryMartin-NOAA
Copy link
Contributor

This PR is intended to replace #9 and only includes git submodules and build changes.

I tested and it compiles for the FV3 case on Hera on the Rocky8 login nodes. I did not yet test for MPAS or on Orion.

@TingLei-NOAA
Copy link
Contributor

@CoryMartin-NOAA Thanks for providing a version working with Rocky 8. Does this mean this branch will work after tomorrow's hera upgrade to Rocky8?

@CoryMartin-NOAA
Copy link
Contributor Author

@TingLei-NOAA it works now if you log in to one of the rocky8 nodes, after tomorrow's maintenance, those will be the default option.

@TingLei-NOAA
Copy link
Contributor

The clone and building of rdas of this PR on hera had succeeded. Though mpi-jedi related components are missing, it is fine. We can add it later as done in #9. Also, as our discussion on rdas including those around #9, I think it is great to have a RDAS repo to work as a starting point. Further discussion/collaboration could continue by more and more use/developments of RDASapp on github. The PR is approved and Thanks to @CoryMartin-NOAA for this effort.

@CoryMartin-NOAA
Copy link
Contributor Author

@TingLei-NOAA did you try it for mpas, did it work?

@CoryMartin-NOAA CoryMartin-NOAA marked this pull request as ready for review March 20, 2024 19:02
@TingLei-NOAA
Copy link
Contributor

@CoryMartin-NOAA running "build.sh -f -a -d -t hera" , mpas (mpas-jedi) is not built in bundle dir. But I saw mpas and mpas-jedi are in sorc dir as the submodules. Maybe some options should be turned on? I will have a look at that later.

@CoryMartin-NOAA
Copy link
Contributor Author

./build.sh -m mpas should do the trick (I hope!)

Copy link
Contributor

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CoryMartin-NOAA. I also cloned and built on hera with rocky 8. I think everything looks good. Thanks for this effort!

@CoryMartin-NOAA CoryMartin-NOAA merged commit 9fc953a into develop Mar 21, 2024
3 checks passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/submodules-rocky8 branch March 21, 2024 15:14
@ShunLiu-NOAA
Copy link

@CoryMartin-NOAA Thank you for updating RDASApp!

delippi pushed a commit to delippi/RDASApp that referenced this pull request May 23, 2024
* Add submodules; update modulefiles; modify build scripts

* Submodule helper scripts

* Update detect_machine.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants