Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace w3nco with w3emc. #461

Closed
aerorahul opened this issue Mar 18, 2022 · 4 comments · Fixed by #528
Closed

Replace w3nco with w3emc. #461

aerorahul opened this issue Mar 18, 2022 · 4 comments · Fixed by #528

Comments

@aerorahul
Copy link
Contributor

Description

w3nco has been merged with w3emc and the latter is preferred going forward.
w3emc/2.9.1+ contains identical code as w3nco with the exception of gblevents.
This project does not depend on gblevents.

Solution

Replace dependency of w3nco with w3emc in the modulefile as well as in the build system.

Alternatives

None.

@WenMeng-NOAA
Copy link
Collaborator

@kgerheiser, @Hang-Lei-NOAA, @aerorahul I got failure for replacing w3nco with w3emc/2.9.1 on Cray as:

-- Found bacio: /usrx/local/nceplibs/NCEPLIBS/cmake/install/NCEPLIBS-v1.3.0/bacio/bacio-2.4.1/lib/libbacio_4.a (found version "2.4.0")
CMake Error at /gpfs/hps/usrx/local/prod/cmake/3.16.2/share/cmake-3.16/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
  Could not find a package configuration file provided by "w3nco" with any of
  the following names:

    w3ncoConfig.cmake
    w3nco-config.cmake

  Add the installation prefix of "w3nco" to CMAKE_PREFIX_PATH or set
  "w3nco_DIR" to a directory containing one of the above files.  If "w3nco"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /usrx/local/nceplibs/NCEPLIBS/cmake/install/NCEPLIBS-v1.3.0/nemsio/nemsio-2.5.2/lib/cmake/nemsio/nemsio-config.cmake:41 (find_dependency)
  CMakeLists.txt:56 (find_package)


-- Configuring incomplete, errors occurred!

My UPP working version is at /u/Wen.Meng/ptmp/develop/UPP on Surge. The build script is UPP/tests/compile_upp.sh.
I updated the following files:

        modified:   CMakeLists.txt
        modified:   modulefiles/wcoss_cray
        modified:   sorc/ncep_post.fd/CMakeLists.txt

Any suggestions on fixing? Thanks!

@kgerheiser
Copy link
Contributor

kgerheiser commented Apr 26, 2022

@WenMeng-NOAA this line needs to be changed to w3emc

find_package(w3nco REQUIRED)

As well as this line

w3nco::w3nco_4

@WenMeng-NOAA
Copy link
Collaborator

@kgerheiser I did change them. Somehow, it works on Dell, Hera, Orion but not Cray. It seems to me the configuration of NCEPLIBS on Cray is different from other platforms.

@WenMeng-NOAA
Copy link
Collaborator

@kgerheiser @aerorahul My branch for replacing w3nco with w3emc/2.9.1 failed at "All checks" on github. It seems to me this online build function is loading w3emc/2.7. from /home/runner/w3emc-2.7.3. Any suggestions on the fix. Thanks!

@WenMeng-NOAA WenMeng-NOAA linked a pull request Jun 29, 2022 that will close this issue
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
Add cycldef for saving INPUT files from ensemble DA in certain cycle
Bug fixes to run RRFS ensemble DA on WCOSS2

Co-authored-by: emc lam <emc.lam@dlogin03.dogwood.wcoss2.ncep.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants