Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to spack-stack 1.6.0 #844

Closed
DavidHuber-NOAA opened this issue Jan 3, 2024 · 10 comments · Fixed by #856
Closed

Upgrade to spack-stack 1.6.0 #844

DavidHuber-NOAA opened this issue Jan 3, 2024 · 10 comments · Fixed by #856
Assignees
Labels
enhancement New feature or request

Comments

@DavidHuber-NOAA
Copy link
Collaborator

DavidHuber-NOAA commented Jan 3, 2024

The UPP should be upgraded to use the newest suite of spack-stack libraries (version 1.6.0). This includes an upgrade of CRTM to 2.4.0.1 and netcdf-fortran to 4.6.1.

@WenMeng-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Thanks for bringing this upgrade to our attention. If you will work on a PR, the UPP code contribution procedure can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#contribute-changes-to-the-upp-main-development-branch-develop

@WenMeng-NOAA WenMeng-NOAA added the enhancement New feature or request label Jan 9, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this issue Jan 17, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this issue Jan 17, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this issue Jan 22, 2024
@WenMeng-NOAA WenMeng-NOAA linked a pull request Jan 23, 2024 that will close this issue
WenMeng-NOAA pushed a commit that referenced this issue Jan 29, 2024
* Upgrade to spack-stack v1.6.0, remove cheyenne. #844

* Loosen up CI concretizer for sp. #844

* Update CI/ip version to SS version.

* Revert unify to true. #844

* Change prod-util to prod_util on MSU.
@DavidHuber-NOAA
Copy link
Collaborator Author

@WenMeng-NOAA I apologize for not posting this sooner, but there is an issue with the CRTM spectral coefficient file amsua_metop-c.SpcCoeff.bin. The details on this file are available in this issue: JCSDA/spack-stack#963. I am not sure if this affects the UPP or not. If so, then the baselines may change again when the correct fix file is copied over.

@FernandoAndrade-NOAA
Copy link
Collaborator

@WenMeng-NOAA I apologize for not posting this sooner, but there is an issue with the CRTM spectral coefficient file amsua_metop-c.SpcCoeff.bin. The details on this file are available in this issue: JCSDA/spack-stack#963. I am not sure if this affects the UPP or not. If so, then the baselines may change again when the correct fix file is copied over.

Understood, thanks for the notice!

@WenMeng-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Thanks for the heads-up. Please let us know when corrected crtm fix files are available on Hera and Orion. We can conduct testing and update baselines if needed.

@DavidHuber-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA @WenMeng-NOAA The CRTM-fix file has been updated on Orion, so you may wish to test the UPP against it. I will be testing it in the GSI today and if it works well, then I will ask for it to be placed on Hera and the other tier-1 and tier-2 systems. I will let you know again when all systems have it and/or if the GSI testing reveals anything else needs to be updated.

@DavidHuber-NOAA
Copy link
Collaborator Author

DavidHuber-NOAA commented Feb 2, 2024

@WenMeng-NOAA @FernandoAndrade-NOAA The corrected CRTM fix file have been pushed to all machines, so you should be good to recheck baselines everywhere. (Apologies for initially posting this to the PR).

The test results were as expected within the GSI WRT the CRTM fix files..

@WenMeng-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Thanks for the heads-up.
@FernandoAndrade-NOAA From the testing at my end on Orion and Hera, no baseline re-creation is needed.

@FernandoAndrade-NOAA
Copy link
Collaborator

@DavidHuber-NOAA Thanks for the heads-up. @FernandoAndrade-NOAA From the testing at my end on Orion and Hera, no baseline re-creation is needed.

Thanks for the notice, I have RTs running on Hera and Orion and will update here with the results.

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Feb 4, 2024

RTs finished on Hera and Orion with no changes in results from my logs, thanks!

@DavidHuber-NOAA
Copy link
Collaborator Author

Great, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants