Cleaning up GRIB2 encoding for index 508 (max precip rate) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EricJames-NOAA Can you sync your branch with the latest UPP develop? |
|
The UPP RT tests were conducted on WCOSS2. This PR will fix the max PRATE issue in 3DRTMA test too since it uses the same control file fv3lam_rrfs.xml as RRFS. @EdwardColon-NOAA Please be aware of the fix for 3DRTMA. |
|
Thank you for letting me know, Wen. I'll take this into account as more
3D-RTMA-specific development proceeds.
…-Edward
On Tue, May 23, 2023 at 1:47 PM WenMeng-NOAA ***@***.***> wrote:
The UPP RT tests were conducted on WCOSS2. This PR will fix the max PRATE
issue in 3DRTMA test too since it uses the same control file
fv3lam_rrfs.xml as RRFS.
Before: record 768 in dataset PRSLEV00.tm00 has issue in grib2 head as
** ERROR bad grib message: Statistical Processing bad n=0 **
768:708561531:d=2023040400:PRATE:surface::
*** FATAL ERROR (delayed): PDT size error
*** FATAL ERROR (delayed): forecast time
Now it is fixed as:
768:708561531:d=2023040400:PRATE:surface:0-0 day max fcst:
@EdwardColon-NOAA <https://github.com/EdwardColon-NOAA> Please be aware
of the fix for 3DRTMA.
—
Reply to this email directly, view it on GitHub
<#708 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFXXQAYBZVP75TVOSTOKP3XHTZ2RANCNFSM6AAAAAAYIGJVDI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-------------------------------------------------
Edward Colón
*Lynker* at NOAA/NWS/NCEP/EMC
5830 University Research Ct.
Rm #2025
Riverdale, MD 20737
Office: (301) 683-3815
Cell: (301) 213-3566
|
|
@EricJames-NOAA Please let me know if my testing for 3DRTMA is not consistent with your testing. |
|
@FernandoAndrade-NOAA You may start the RT tests on Hera and Orion and would expect changed results for 3DRTMA. |
@WenMeng-NOAA your results are in agreement with mine! Thanks for your test! |
|
UPP RTs have finished on Hera and Orion. @WenMeng-NOAA could you adjust the permissions for the recreated data for Orion from earlier? Tests failed due to permission issues. I can run RTs again after that. On Hera the following changes in test results for 3drtma PRSLEV00: |
The changed results of 3DRTMA on Hera are consistent with mine on WCOSS2. I just changed the permission on Orion. Please try again. @FernandoAndrade-NOAA |
WenMeng-NOAA
approved these changes
May 24, 2023
FernandoAndrade-NOAA
approved these changes
May 24, 2023
|
This PR is ready for merging. A new baseline is needed to be created for 3DRTMA. |
WenMeng-NOAA
added
the
Baseline Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the GRIB2 encoding for index 508, 1-h max precip rate. The previous code was causing problems with wgrib2 for the 0-h forecast.
The change was tested for the RRFS_CONUS_3km system on Jet.