[develop] Updates to Users Guide and Tables #722
Conversation
…into text/ug-updates
There was a problem hiding this comment.
@gspetro-NOAA I didn't quite make it through this document. I will be back in the office on the 29th and can finish that day if you are able to wait.
Many are just spelling out acronyms, or being a bit more specific, which is up to you to take or leave
docs/UPP_GRIB2_Table_byID.csv
Outdated
| Freezing level RH,RH_ON_0C_ISOTHERM,RH,63 | ||
| 10 M u-component wind,UGRD_ON_SPEC_HGT_LVL_ABOVE_GRND_10m,UGRD,64 | ||
| 10 M v-component wind,VGRD_ON_SPEC_HGT_LVL_ABOVE_GRND_10m,VGRD,65 | ||
| **Relative humidity on sigma levels 0.33-1.0**,RH_ON_SIGMA_LVL_0.33-1.0,RH,66 |
There was a problem hiding this comment.
Relative humidity on sigma layer (0.33-1.00 mean)
There was a problem hiding this comment.
Finished! Just a handful more changes. One comment about a number of the older satellite products, esp the ones that state not available for grib2 output, they are not in post_avblflds and maybe should not be in this table. They are slated for removal when they get a chance. You could remove them from this table now.
There was a problem hiding this comment.
Looks, may be good to do a stand-alone test to ensure these produce expected results since they were not tested for grib2 output. If you decide to do that, let me know if you need help with that, it is not time consuming if you already have UPP built and have simple test data.
@FernandoAndrade-NOAA Do you know how to do this? Otherwise, I will need some help, @hertneky . |
WenMeng-NOAA
added
No Baseline Change
|
@FernandoAndrade-NOAA If you have UPP RT tests and UPP standalone test for VTMP, please note them. |
|
@hertneky Do you think any requested changes are not updated? |
|
@WenMeng-NOAA VTMP Standalone test results with VTMP and hafs are located in the following location with changes in HURPRS09.tm00: |
It looks like all changes have been made. |
There was a problem hiding this comment.
Final changes look good, @FernandoAndrade-NOAA mentioned he tested the VTMP additions stand-alone. The virtual temperature output in his tests look reasonable. Thanks for testing that!
Thanks for confirming! |
@FernandoAndrade-NOAA Your test results for VTMP look good to me. |
|
@FernandoAndrade-NOAA Please approve this PR. |
|
This PR is ready for merging. |
This PR updates the UPP User's Guide and associated tables. A human-friendly version of the docs on my fork can be viewed here: https://gsp-upp.readthedocs.io/en/text-ug-updates/
Update Tables (added/deleted fields)***:
***Note that additions appear with ** around the name (rendered as bold type on ReadTheDocs). Someone should double-check these to verify accuracy, since the documentation was not always clear. I will remove the ** before merging.
Update User's Guide
Additionally, this PR updates the list of prerequisites in the README.md file. This should resolve Issue #723 .