Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UPP for GFS V17 #736

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

WenMeng-NOAA
Copy link
Collaborator

The changes are:

  • Output composite radar reflectivity when GFS uses Thompson MP
  • Add six winter weather variables in pgrb2 dataset

@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Jun 26, 2023
@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RT tests were completed on WCOSS2. There will be a baseline recreation for GFS due to new variables added in pgrb2 dataset.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA Please conduct the UPP RT tests on Hera and Orion. You would expect all tests passed:

  • 3D radar reflectivity not in model files for GFS RT testing
  • GFS pgrb2 data file not in test result comparison

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA Please conduct the UPP RT tests on Hera and Orion. You would expect all tests passed:

* 3D radar reflectivity not in  model files for GFS RT testing

* GFS pgrb2 data file not in test result comparison

Sure thing, I can run RTs on Hera, but I'm still waiting on the Orion account issue to be resolved so I can't run on there just yet.

@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA Please conduct the UPP RT tests on Hera and Orion. You would expect all tests passed:

* 3D radar reflectivity not in  model files for GFS RT testing

* GFS pgrb2 data file not in test result comparison

Sure thing, I can run RTs on Hera, but I'm still waiting on the Orion account issue to be resolved so I can't run on there just yet.

@FernandoAndrade-NOAA That's fine. I can run tests on Orion.

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RT tests were completed on Orion with no changed results.

@FernandoAndrade-NOAA
Copy link
Collaborator

UPP RTs on Hera have finished with no changes to results

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging. The baseline of GFS will be recreated.

@WenMeng-NOAA WenMeng-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Jun 26, 2023
@WenMeng-NOAA WenMeng-NOAA merged commit 0544d07 into NOAA-EMC:develop Jun 26, 2023
4 checks passed
@WenMeng-NOAA WenMeng-NOAA deleted the post_radar branch October 4, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. GFSV17 Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output column radar reflectivity for GFS V17 New Products for GFS V17
3 participants