Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Add Doxygen variable definitions to modules #965

Merged
merged 109 commits into from
Jul 8, 2024

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Jun 6, 2024

This PR updates documentation in the following files:

doc/Doxyfile.in --> Removed extra = and updated file using doxygen -u Doxyfile.in to resolve warnings.
UFS_unified_variables_table.csv - fix typo
BOUND.f
BNDLYR.f
CALDWP.f
CALGUST.f
CALHEL.f
CMASSI.f
CTLBLK.f
FRZLVL2.f
GFIP3.f
GFSPOSTSIG.F
IFI.F
LOOKUP.f
MASKS_mod.f
MISCLN.f
PARA_RANGE.f
READ_xml.f
RHGRD.f
RQSTFLD.f
SET_LVLSXML.f
SOIL_mod.f
TRPAUS.f
UPP_PHYSICS.f
VRBLS2D.f
VRBLS3D.f
VRBLS4D.f
cuparm.f
grib2_module.f
gtg_filter.F90
gtg_indices.F90
gtg_read_config.F90
intio_tags.f
machine.f
params.F
physcons.f
svptbl.f
sorc/ncep_post.fd/wrf_io_flags.f
xml_perl_data.f
ZENSUN.f

This PR largely addresses Issue #392 and warnings that came up in modules after documenting routines for that issue.

Authors: @gspetro-NOAA, @jdkublnick

@gspetro-NOAA gspetro-NOAA marked this pull request as ready for review July 2, 2024 15:22
@FernandoAndrade-NOAA FernandoAndrade-NOAA added the Ready for Review This PR is ready for code review. label Jul 8, 2024
Copy link
Collaborator

@FernandoAndrade-NOAA FernandoAndrade-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in RT results on Hera.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Jul 8, 2024
@WenMeng-NOAA
Copy link
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 60d1cbb into NOAA-EMC:develop Jul 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants