Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model fails when output bundle contains no fields #676

Closed
DusanJovic-NOAA opened this issue Jul 3, 2023 · 0 comments · Fixed by #679
Closed

Model fails when output bundle contains no fields #676

DusanJovic-NOAA opened this issue Jul 3, 2023 · 0 comments · Fixed by #679
Assignees
Labels
bug Something isn't working

Comments

@DusanJovic-NOAA
Copy link
Collaborator

Description

If for whatever reason one of the output bundles is empty (ie. there are no fields added to it) model will crash with this error:

20230703 181812.557 ERROR            PET144 ESMF_FieldBundle.F90:11312 ESMF_FieldBundleGetListAll() Invalid object  -  - fieldbundle does not have a geombase object stored
20230703 181812.557 ERROR            PET144 module_wrt_grid_comp.F90:880 Invalid object  - Passing error in return code
20230703 181812.557 ERROR            PET144 fv3_cap.F90:542 Invalid object  - Passing error in return code
20230703 181812.557 ERROR            PET144 ATM:src/addon/NUOPC/src/NUOPC_ModelBase.F90:700 Invalid object  - Passing error in return code
20230703 181812.557 ERROR            PET144 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:2577 Invalid object  - Phase 'IPDvXp01' Initialize for modelComp 1: ATM did not return
ESMF_SUCCESS
20230703 181812.557 ERROR            PET144 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:1286 Invalid object  - Passing error in return code
20230703 181812.557 ERROR            PET144 UFS Driver Grid Comp:src/addon/NUOPC/src/NUOPC_Driver.F90:457 Invalid object  - Passing error in return code
20230703 181812.557 ERROR            PET144 UFS.F90:386 Invalid object  - Aborting UFS
20230703 181812.557 INFO             PET144 Finalizing ESMF

For example, if diag_table is:

20210322.06Z.C96.64bit.non-mono
2021 03 22 06 0 0

"fv3_history",    0,  "hours",  1,  "hours",  "time"
"fv3_history2d",  0,  "hours",  1,  "hours",  "time"

"gfs_dyn",     "ps",          "pressfc",   "fv3_history",    "all",  .false.,  "none",  2

"gfs_phys",    "psurf",       "pressfc",   "fv3_history2d",  "all",  .false.,  "none",  2

This happens because all fields that will go to physics output are separated into two bundles, one containing fields that will be interpolated using bilinear interpolation method and another using nearest neighbor method. In the above example, physics file will contain only one field (psurf), and it will be interpolated using a bilinear method, which means the bundle for the nearest neighbor will have no fields.

To Reproduce:

What compilers/machines are you seeing this with? Intel/Hera
Give explicit steps to reproduce the behavior.

  1. clone current develop branch
  2. run one of the ufs-weather-model regression tests (for example control_p8) and change diag_table as shown above
  3. then, oops, look at the bug

Additional context

Add any other context about the problem here.
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • needs to be fixed also in noaa-emc/nems/issues/<issue_number>
  • needed for noaa-emc/fv3atm/pull/<pr_number>

Output

output logs
If applicable, include relevant output logs.
Either drag and drop the entire log file here (if a long log) or

paste the code here (if a short section of log)

Testing:

  1. Have you tested the code changes? On what platforms?

  2. Have you run regression test in ufs-weather-model or ufs-s2s-model with code changes?

  • Will the baseline results change?
  • If the baseline results change, is it expected? Please give brief explanation.

Dependent PRs:

Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:

  • required to support noaa-emc/GFDL_atmos_cubed_sphere/issues/<issue_number>
  • ncar/ccpp-physics/pull/<pr_number>
  • associated ufs-weather-model/pull/<pr_number>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant